@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
PHUIDocumentViewPro tweaks
Summary: Use in MailCommands and HTTP Parameters
Test Plan: Tested MailCommands in Paste, HTTP Parameters in Paste, Legalpad, Diviner. Mobile and Desktop breakpoints.
Reviewers: epriestley
Reviewed By: epriestley
Subscribers: Korvin
Differential Revision: https://secure.phabricator.com/D14397
+21
-30
+5
-5
resources/celerity/map.php
+5
-5
resources/celerity/map.php
···
7
7
*/
8
8
return array(
9
9
'names' => array(
10
-
'core.pkg.css' => 'a9b47b99',
10
+
'core.pkg.css' => 'a79276eb',
11
11
'core.pkg.js' => '47dc9ebb',
12
12
'darkconsole.pkg.js' => 'e7393ebb',
13
13
'differential.pkg.css' => '2de124c9',
···
126
126
'rsrc/css/phui/phui-box.css' => 'a5bb366d',
127
127
'rsrc/css/phui/phui-button.css' => '16020a60',
128
128
'rsrc/css/phui/phui-crumbs-view.css' => 'd842f867',
129
-
'rsrc/css/phui/phui-document-pro.css' => '5f86a934',
129
+
'rsrc/css/phui/phui-document-pro.css' => '61d70f8e',
130
130
'rsrc/css/phui/phui-document.css' => '9fa715d2',
131
131
'rsrc/css/phui/phui-feed-story.css' => 'b7b26d23',
132
132
'rsrc/css/phui/phui-fontkit.css' => 'c9d63950',
···
136
136
'rsrc/css/phui/phui-icon.css' => 'b0a6b1b6',
137
137
'rsrc/css/phui/phui-image-mask.css' => '5a8b09c8',
138
138
'rsrc/css/phui/phui-info-panel.css' => '27ea50a1',
139
-
'rsrc/css/phui/phui-info-view.css' => 'fdabaa73',
139
+
'rsrc/css/phui/phui-info-view.css' => '6d7c3509',
140
140
'rsrc/css/phui/phui-list.css' => '125599df',
141
141
'rsrc/css/phui/phui-object-box.css' => '407eaf5a',
142
142
'rsrc/css/phui/phui-object-item-list-view.css' => '26c30d3f',
···
781
781
'phui-calendar-month-css' => '476be7e0',
782
782
'phui-crumbs-view-css' => 'd842f867',
783
783
'phui-document-view-css' => '9fa715d2',
784
-
'phui-document-view-pro-css' => '5f86a934',
784
+
'phui-document-view-pro-css' => '61d70f8e',
785
785
'phui-feed-story-css' => 'b7b26d23',
786
786
'phui-font-icon-base-css' => 'ecbbb4c2',
787
787
'phui-fontkit-css' => 'c9d63950',
···
791
791
'phui-icon-view-css' => 'b0a6b1b6',
792
792
'phui-image-mask-css' => '5a8b09c8',
793
793
'phui-info-panel-css' => '27ea50a1',
794
-
'phui-info-view-css' => 'fdabaa73',
794
+
'phui-info-view-css' => '6d7c3509',
795
795
'phui-inline-comment-view-css' => '0fdb3667',
796
796
'phui-list-view-css' => '125599df',
797
797
'phui-object-box-css' => '407eaf5a',
+3
-1
src/applications/meta/controller/PhabricatorApplicationEmailCommandsController.php
+3
-1
src/applications/meta/controller/PhabricatorApplicationEmailCommandsController.php
···
115
115
$crumbs = $this->buildApplicationCrumbs();
116
116
$this->addApplicationCrumb($crumbs, $selected);
117
117
$crumbs->addTextCrumb($title);
118
+
$crumbs->setBorder(true);
118
119
119
120
$content_box = PhabricatorMarkupEngine::renderOneObject(
120
121
id(new PhabricatorMarkupOneOff())->setContent($content),
···
134
135
$header = id(new PHUIHeaderView())
135
136
->setHeader($title);
136
137
137
-
$document = id(new PHUIDocumentView())
138
+
$document = id(new PHUIDocumentViewPro())
138
139
->setHeader($header)
139
140
->appendChild($info_view)
140
141
->appendChild($content_box);
···
146
147
),
147
148
array(
148
149
'title' => $title,
150
+
'class' => 'pro-white-background',
149
151
));
150
152
151
153
}
+3
-3
src/applications/transactions/editengine/PhabricatorApplicationEditEngine.php
+3
-3
src/applications/transactions/editengine/PhabricatorApplicationEditEngine.php
···
370
370
371
371
$crumbs = $this->buildCrumbs($object);
372
372
$crumbs->addTextCrumb(pht('HTTP Parameters'));
373
+
$crumbs->setBorder(true);
373
374
374
375
$header = id(new PHUIHeaderView())
375
376
->setHeader(
···
377
378
'HTTP Parameters: %s',
378
379
$this->getObjectCreateShortText($object)));
379
380
380
-
// TODO: Upgrade to DocumentViewPro.
381
-
382
-
$document = id(new PHUIDocumentView())
381
+
$document = id(new PHUIDocumentViewPro())
383
382
->setUser($viewer)
384
383
->setHeader($header);
385
384
···
391
390
return $controller->newPage()
392
391
->setTitle(pht('HTTP Parameters'))
393
392
->setCrumbs($crumbs)
393
+
->addClass('pro-white-background')
394
394
->appendChild($document);
395
395
}
396
396
+5
-17
src/applications/transactions/view/PhabricatorApplicationEditHTTPParameterHelpView.php
+5
-17
src/applications/transactions/view/PhabricatorApplicationEditHTTPParameterHelpView.php
···
306
306
307
307
return array(
308
308
$this->renderInstructions($intro),
309
-
$this->renderTable($main_table),
309
+
$main_table,
310
310
$this->renderInstructions($aliases_text),
311
-
$this->renderTable($alias_table),
311
+
$alias_table,
312
312
$this->renderInstructions($select_text),
313
-
$this->renderTable($select_table),
313
+
$select_table,
314
314
$this->renderInstructions($types_text),
315
-
$this->renderTable($types_table),
315
+
$types_table,
316
316
);
317
317
}
318
318
319
-
protected function renderTable(AphrontTableView $table) {
320
-
return id(new PHUIBoxView())
321
-
->addMargin(PHUI::MARGIN_LARGE_LEFT)
322
-
->addMargin(PHUI::MARGIN_LARGE_RIGHT)
323
-
->addMargin(PHUI::MARGIN_LARGE_BOTTOM)
324
-
->appendChild($table);
325
-
}
326
-
327
319
protected function renderInstructions($corpus) {
328
320
$viewer = $this->getUser();
329
-
330
-
return id(new PHUIBoxView())
331
-
->addMargin(PHUI::MARGIN_SMALL_TOP)
332
-
->addMargin(PHUI::MARGIN_SMALL_BOTTOM)
333
-
->appendChild(new PHUIRemarkupView($viewer, $corpus));
321
+
return new PHUIRemarkupView($viewer, $corpus);
334
322
}
335
323
336
324
}
+5
webroot/rsrc/css/phui/phui-document-pro.css
+5
webroot/rsrc/css/phui/phui-document-pro.css
···
94
94
95
95
.device-phone .phui-document-view.phui-document-view-pro .phui-header-shell {
96
96
margin: 8px 0 0 0;
97
+
padding: 8px 0 20px;
97
98
}
98
99
99
100
.phui-document-view.phui-document-view-pro .phui-header-tall
···
107
108
display: block;
108
109
padding: 8px 0 0 0;
109
110
}
111
+
112
+
.phui-document-view-pro .phui-info-view {
113
+
margin: 16px 0 0 0;
114
+
}