@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Disappear PhabricatorObjectItemView's empty tooltips if is empty
Test Plan: removed one or two labels from uiexample, verified expected behaviour
Reviewers: epriestley
Reviewed By: epriestley
CC: aran, Korvin
Differential Revision: https://secure.phabricator.com/D5382
authored by
Anh Nhan Nguyen
and committed by
epriestley
3b5d9ff7
17b9ac41
+11
-8
+11
-8
src/view/layout/PhabricatorObjectItemView.php
+11
-8
src/view/layout/PhabricatorObjectItemView.php
···
288
288
private function renderHandleIcon(PhabricatorObjectHandle $handle, $label) {
289
289
Javelin::initBehavior('phabricator-tooltips');
290
290
291
+
$options = array(
292
+
'class' => 'phabricator-object-item-handle-icon',
293
+
'style' => 'background: url('.$handle->getImageURI().')',
294
+
);
295
+
296
+
if (strlen($label)) {
297
+
$options['sigil'] = 'has-tooltip';
298
+
$options['meta'] = array('tip' => $label);
299
+
}
300
+
291
301
return javelin_tag(
292
302
'span',
293
-
array(
294
-
'class' => 'phabricator-object-item-handle-icon',
295
-
'sigil' => 'has-tooltip',
296
-
'style' => 'background: url('.$handle->getImageURI().')',
297
-
'meta' => array(
298
-
'tip' => $label,
299
-
),
300
-
),
303
+
$options,
301
304
'');
302
305
}
303
306