@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Remove an unneeded condition in PHUITimelineEventView.php
Summary: Since rP40e9806e3c88500a67d382a5ec07594325f1b000 changing `if ($items || $has_menu)` to `if ($items)`, the ternary operator condition `$items ? 'a' : 'span'` is always true.
Test Plan: Read the code; run static code analysis.
Reviewers: O1 Blessed Committers, valerio.bozzolan
Reviewed By: O1 Blessed Committers, valerio.bozzolan
Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno
Differential Revision: https://we.phorge.it/D25976
+3
-7
+3
-7
src/view/phui/PHUITimelineEventView.php
+3
-7
src/view/phui/PHUITimelineEventView.php
···
348
348
),
349
349
pht('Comment Actions'));
350
350
351
-
if ($items) {
352
-
$sigil = 'phui-dropdown-menu';
353
-
Javelin::initBehavior('phui-dropdown-menu');
354
-
} else {
355
-
$sigil = null;
356
-
}
351
+
$sigil = 'phui-dropdown-menu';
352
+
Javelin::initBehavior('phui-dropdown-menu');
357
353
358
354
$action_list = id(new PhabricatorActionListView())
359
355
->setViewer($this->getUser());
···
362
358
}
363
359
364
360
$menu = javelin_tag(
365
-
$items ? 'a' : 'span',
361
+
'a',
366
362
array(
367
363
'href' => '#',
368
364
'class' => 'phui-timeline-menu',