@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix double feed stories in Phame
Summary:
Ref T9360. Fixes the double-rendering of post bodies in feed stories.
Downside is that 'publish' (on its own) no longer shows a body, but that seems fine.
Test Plan:
- Got some double bodies.
- Applied patch.
- No more double bodies.
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T9360
Differential Revision: https://secure.phabricator.com/D14748
+2
-16
+2
-16
src/applications/phame/storage/PhamePostTransaction.php
+2
-16
src/applications/phame/storage/PhamePostTransaction.php
···
190
190
}
191
191
192
192
public function getRemarkupBodyForFeed(PhabricatorFeedStory $story) {
193
-
$text = null;
194
193
switch ($this->getTransactionType()) {
195
-
case self::TYPE_TITLE:
196
-
if ($this->getOldValue() === null) {
197
-
$post = $story->getPrimaryObject();
198
-
$text = $post->getBody();
199
-
}
200
-
break;
201
-
case self::TYPE_VISIBILITY:
202
-
if ($this->getNewValue() == PhameConstants::VISIBILITY_PUBLISHED) {
203
-
$post = $story->getPrimaryObject();
204
-
$text = $post->getBody();
205
-
}
206
-
break;
207
194
case self::TYPE_BODY:
208
-
$text = $this->getNewValue();
209
-
break;
195
+
return $this->getNewValue();
210
196
}
211
197
212
-
return $text;
198
+
return null;
213
199
}
214
200
215
201
public function getColor() {