@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Make "Tags" and "Branches" custom fields work properly in Diffusion
Summary: Ref T8295 (vaguely related). This old method has no callsites.
Test Plan: Generated mail, saw "Tags" and "Branches".
Reviewers: fabe, joshuaspence
Reviewed By: fabe, joshuaspence
Subscribers: epriestley
Maniphest Tasks: T8295
Differential Revision: https://secure.phabricator.com/D13000
+10
-24
+5
-4
src/applications/repository/customfield/PhabricatorCommitBranchesField.php
+5
-4
src/applications/repository/customfield/PhabricatorCommitBranchesField.php
···
7
7
return 'diffusion:branches';
8
8
}
9
9
10
-
public function shouldAppearInApplicationTransactions() {
10
+
public function shouldAppearInTransactionMail() {
11
11
return true;
12
12
}
13
13
14
-
public function buildApplicationTransactionMailBody(
15
-
PhabricatorApplicationTransaction $xaction,
16
-
PhabricatorMetaMTAMailBody $body) {
14
+
public function updateTransactionMailBody(
15
+
PhabricatorMetaMTAMailBody $body,
16
+
PhabricatorApplicationTransactionEditor $editor,
17
+
array $xactions) {
17
18
18
19
$params = array(
19
20
'contains' => $this->getObject()->getCommitIdentifier(),
+5
-4
src/applications/repository/customfield/PhabricatorCommitTagsField.php
+5
-4
src/applications/repository/customfield/PhabricatorCommitTagsField.php
···
7
7
return 'diffusion:tags';
8
8
}
9
9
10
-
public function shouldAppearInApplicationTransactions() {
10
+
public function shouldAppearInTransactionMail() {
11
11
return true;
12
12
}
13
13
14
-
public function buildApplicationTransactionMailBody(
15
-
PhabricatorApplicationTransaction $xaction,
16
-
PhabricatorMetaMTAMailBody $body) {
14
+
public function updateTransactionMailBody(
15
+
PhabricatorMetaMTAMailBody $body,
16
+
PhabricatorApplicationTransactionEditor $editor,
17
+
array $xactions) {
17
18
18
19
$params = array(
19
20
'commit' => $this->getObject()->getCommitIdentifier(),
-16
src/infrastructure/customfield/field/PhabricatorCustomField.php
-16
src/infrastructure/customfield/field/PhabricatorCustomField.php
···
1055
1055
return false;
1056
1056
}
1057
1057
1058
-
/**
1059
-
* TODO: this is only used by Diffusion right now and everything is completely
1060
-
* faked since Diffusion doesn't use ApplicationTransactions yet. This should
1061
-
* get fleshed out as we have more use cases.
1062
-
*
1063
-
* @task appxaction
1064
-
*/
1065
-
public function buildApplicationTransactionMailBody(
1066
-
PhabricatorApplicationTransaction $xaction,
1067
-
PhabricatorMetaMTAMailBody $body) {
1068
-
if ($this->proxy) {
1069
-
return $this->proxy->buildApplicationTransactionMailBody($xaction, $body);
1070
-
}
1071
-
return;
1072
-
}
1073
-
1074
1058
1075
1059
/* -( Transaction Mail )--------------------------------------------------- */
1076
1060