@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Use PhabricatorObjectListQuery in Herald worker
Summary: Ref T2222. Straightforward, just breaks a needless dependency.
Test Plan: Pushed and parsed a commit with "Auditors" in it.
Reviewers: btrahan
Reviewed By: btrahan
CC: aran
Maniphest Tasks: T2222
Differential Revision: https://secure.phabricator.com/D8473
+10
-4
+10
-4
src/applications/repository/worker/PhabricatorRepositoryCommitHeraldWorker.php
+10
-4
src/applications/repository/worker/PhabricatorRepositoryCommitHeraldWorker.php
···
270
270
return array();
271
271
}
272
272
273
-
$phids = DifferentialFieldSpecification::parseCommitMessageObjectList(
274
-
$matches[1],
275
-
$include_mailables = false,
276
-
$allow_partial = true);
273
+
$phids = id(new PhabricatorObjectListQuery())
274
+
->setViewer(PhabricatorUser::getOmnipotentUser())
275
+
->setAllowPartialResults(true)
276
+
->setAllowedTypes(
277
+
array(
278
+
PhabricatorPeoplePHIDTypeUser::TYPECONST,
279
+
PhabricatorProjectPHIDTypeProject::TYPECONST,
280
+
))
281
+
->setObjectList($matches[1])
282
+
->execute();
277
283
278
284
if (!$phids) {
279
285
return array();