@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Update one straggling "CAN_INTERACT" check in comment removal
Summary: See rPaacc62463d61. D20551 added some `CAN_INTERACT` checks, but `CAN_INTERACT` needs to be checked with `canInteract()` to fall back to `CAN_VIEW` properly. D20558 cleaned up most of this but missed one callsite; fix that up too.
Test Plan: Removed a comment on a commit.
Reviewers: amckinley, 20after4
Reviewed By: amckinley
Differential Revision: https://secure.phabricator.com/D20648
+2
-3
+2
-3
src/applications/transactions/controller/PhabricatorApplicationTransactionCommentRemoveController.php
+2
-3
src/applications/transactions/controller/PhabricatorApplicationTransactionCommentRemoveController.php
···
38
38
// from locked threads.
39
39
40
40
$object = $xaction->getObject();
41
-
$can_interact = PhabricatorPolicyFilter::hasCapability(
41
+
$can_interact = PhabricatorPolicyFilter::canInteract(
42
42
$viewer,
43
-
$object,
44
-
PhabricatorPolicyCapability::CAN_INTERACT);
43
+
$object);
45
44
if (!$can_interact && !$viewer->getIsAdmin()) {
46
45
return $this->newDialog()
47
46
->setTitle(pht('Conversation Locked'))