@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Modernize Conduit app a bit
Summary: Remove some AphrontPanels, add some phts, fix some table layouts.
Test Plan: Browse many Conduit pages, test a few calls.
Reviewers: btrahan, epriestley
Reviewed By: epriestley
Subscribers: Korvin, epriestley
Maniphest Tasks: T7427
Differential Revision: https://secure.phabricator.com/D11957
+20
-28
+7
-17
src/applications/conduit/controller/PhabricatorConduitAPIController.php
+7
-17
src/applications/conduit/controller/PhabricatorConduitAPIController.php
···
532
532
}
533
533
534
534
$param_table = new AphrontTableView($param_rows);
535
-
$param_table->setDeviceReadyTable(true);
536
535
$param_table->setColumnClasses(
537
536
array(
538
537
'header',
···
548
547
}
549
548
550
549
$result_table = new AphrontTableView($result_rows);
551
-
$result_table->setDeviceReadyTable(true);
552
550
$result_table->setColumnClasses(
553
551
array(
554
552
'header',
555
553
'wide',
556
554
));
557
555
558
-
$param_panel = new AphrontPanelView();
559
-
$param_panel->setHeader('Method Parameters');
556
+
$param_panel = new PHUIObjectBoxView();
557
+
$param_panel->setHeaderText(pht('Method Parameters'));
560
558
$param_panel->appendChild($param_table);
561
559
562
-
$result_panel = new AphrontPanelView();
563
-
$result_panel->setHeader('Method Result');
560
+
$result_panel = new PHUIObjectBoxView();
561
+
$result_panel->setHeaderText(pht('Method Result'));
564
562
$result_panel->appendChild($result_table);
565
563
566
-
$param_head = id(new PHUIHeaderView())
567
-
->setHeader(pht('Method Parameters'));
568
-
569
-
$result_head = id(new PHUIHeaderView())
570
-
->setHeader(pht('Method Result'));
571
-
572
564
$method_uri = $this->getApplicationURI('method/'.$method.'/');
573
565
574
566
$crumbs = $this->buildApplicationCrumbs()
···
578
570
return $this->buildApplicationPage(
579
571
array(
580
572
$crumbs,
581
-
$param_head,
582
-
$param_table,
583
-
$result_head,
584
-
$result_table,
573
+
$param_panel,
574
+
$result_panel,
585
575
),
586
576
array(
587
-
'title' => 'Method Call Result',
577
+
'title' => pht('Method Call Result'),
588
578
));
589
579
}
590
580
+13
-11
src/applications/conduit/controller/PhabricatorConduitLogController.php
+13
-11
src/applications/conduit/controller/PhabricatorConduitLogController.php
···
35
35
}
36
36
37
37
$table = $this->renderCallTable($calls, $conns);
38
+
$box = id(new PHUIObjectBoxView())
39
+
->setHeaderText(pht('Call Logs'))
40
+
->appendChild($table);
38
41
39
42
$crumbs = $this->buildApplicationCrumbs();
40
43
$crumbs->addTextCrumb(pht('Call Logs'));
···
42
45
return $this->buildApplicationPage(
43
46
array(
44
47
$crumbs,
45
-
$table,
48
+
$box,
46
49
$pager,
47
50
),
48
51
array(
49
-
'title' => 'Conduit Logs',
52
+
'title' => pht('Conduit Logs'),
50
53
));
51
54
}
52
55
···
100
103
);
101
104
}
102
105
103
-
$table = id(new AphrontTableView($rows))
104
-
->setDeviceReadyTable(true);
106
+
$table = id(new AphrontTableView($rows));
105
107
106
108
$table->setHeaders(
107
109
array(
108
-
'Connection',
109
-
'User',
110
-
'Method',
111
-
'Status',
112
-
'Error',
113
-
'Duration',
114
-
'Date',
110
+
pht('Connection'),
111
+
pht('User'),
112
+
pht('Method'),
113
+
pht('Status'),
114
+
pht('Error'),
115
+
pht('Duration'),
116
+
pht('Date'),
115
117
));
116
118
$table->setColumnClasses(
117
119
array(