@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
UIExamples: Fix missing styling
Summary:
This is a regression from ce3c11dc8685.
Previously, the whole page content was part of the navigation,
which itself was set to be a child of the page container.
This caused several styling issues and was fixed. However, the
page content was still a child of the navigation and navigation
doesn't render included styling.
Closes T16283
Test Plan:
* Look at http://phorge.localhost/uiexample/view/PHUIBadgeExample/
* Look at http://phorge.localhost/uiexample/view/PHUILeftRightExample/
Reviewers: O1 Blessed Committers, aklapper
Reviewed By: O1 Blessed Committers, aklapper
Subscribers: aklapper, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno
Maniphest Tasks: T16283
Differential Revision: https://we.phorge.it/D26389
+7
-8
+7
-8
src/applications/uiexample/controller/PhabricatorUIExampleRenderController.php
+7
-8
src/applications/uiexample/controller/PhabricatorUIExampleRenderController.php
···
48
48
->appendChild($example->getDescription())
49
49
->setSeverity(PHUIInfoView::SEVERITY_NODATA);
50
50
51
-
$nav->appendChild(
52
-
array(
53
-
$crumbs,
54
-
$note,
55
-
$result,
56
-
));
57
-
58
51
return $this->newPage()
59
52
->setTitle($example->getName())
60
-
->setNavigation($nav);
53
+
->setNavigation($nav)
54
+
->appendChild(
55
+
array(
56
+
$crumbs,
57
+
$note,
58
+
$result,
59
+
));
61
60
}
62
61
63
62
}