@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Update out-of-date API calls when rendering diffs inline in email
Summary: See PHI1745. This callsite for "ChangesetParser" was not properly updated for recent changes.
Test Plan:
- Set `metamta.differential.inline-patches` to 100.
- Created a new revision with a small (<100 line) diff, with at least one reviewer.
- Ran `bin/phd debug` and observed outbound mail queue with `bin/mail list-outbound`.
- Before: fatal when trying to generate the inline changes for mail.
- After: clean mail generation.
Differential Revision: https://secure.phabricator.com/D21270
+3
-1
+3
-1
src/applications/differential/mail/DifferentialChangeDetailMailView.php
+3
-1
src/applications/differential/mail/DifferentialChangeDetailMailView.php
···
40
40
$diff = $this->getDiff();
41
41
42
42
$engine = new PhabricatorMarkupEngine();
43
+
$viewstate = new PhabricatorChangesetViewState();
43
44
44
45
$out = array();
45
46
foreach ($diff->getChangesets() as $changeset) {
46
47
$parser = id(new DifferentialChangesetParser())
47
-
->setUser($viewer)
48
+
->setViewer($viewer)
49
+
->setViewState($viewstate)
48
50
->setChangeset($changeset)
49
51
->setLinesOfContext(2)
50
52
->setMarkupEngine($engine);