@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix an issue where builds with no initiator failed to render in build plans
Summary: See PHI1743. If a build has no initiator PHID, the rendering pathway incorrectly tries to access a handle for it anyway.
Test Plan:
- Set a build to have no initiator PHID.
- Viewed the build plan for the build.
- Before: fatal when trying to access the `null` handle.
- After: clean build plan rendering.
Subscribers: PHID-OPKG-gm6ozazyms6q6i22gyam
Differential Revision: https://secure.phabricator.com/D21269
+4
-2
+4
-2
src/applications/harbormaster/view/HarbormasterBuildView.php
+4
-2
src/applications/harbormaster/view/HarbormasterBuildView.php
···
34
34
$list = new PHUIObjectItemListView();
35
35
foreach ($builds as $build) {
36
36
$id = $build->getID();
37
-
$initiator = $handles[$build->getInitiatorPHID()];
37
+
38
38
$buildable_object = $handles[$build->getBuildable()->getBuildablePHID()];
39
39
40
40
$item = id(new PHUIObjectItemView())
···
46
46
->setEpoch($build->getDateCreated())
47
47
->addAttribute($buildable_object->getName());
48
48
49
-
if ($initiator) {
49
+
$initiator_phid = $build->getInitiatorPHID();
50
+
if ($initiator_phid) {
51
+
$initiator = $handles[$initiator_phid];
50
52
$item->addByline($initiator->renderLink());
51
53
}
52
54