@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix method visibility for `PhabricatorRepositoryCommitParserWorker` subclasses
Summary: Ref T6822.
Test Plan: Visual inspection. This method is only called from within the `PhabricatorRepositoryCommitParserWorker` class.
Reviewers: #blessed_reviewers, epriestley
Reviewed By: #blessed_reviewers, epriestley
Subscribers: Korvin, epriestley
Maniphest Tasks: T6822
Differential Revision: https://secure.phabricator.com/D11248
+4
-5
+1
-2
src/applications/repository/worker/PhabricatorRepositoryCommitHeraldWorker.php
+1
-2
src/applications/repository/worker/PhabricatorRepositoryCommitHeraldWorker.php
···
3
3
final class PhabricatorRepositoryCommitHeraldWorker
4
4
extends PhabricatorRepositoryCommitParserWorker {
5
5
6
-
7
6
public function getRequiredLeaseTime() {
8
7
// Herald rules may take a long time to process.
9
8
return phutil_units('4 hours in seconds');
10
9
}
11
10
12
-
public function parseCommit(
11
+
protected function parseCommit(
13
12
PhabricatorRepository $repository,
14
13
PhabricatorRepositoryCommit $commit) {
15
14
+1
-1
src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryGitCommitMessageParserWorker.php
+1
-1
src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryGitCommitMessageParserWorker.php
+1
-1
src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryMercurialCommitMessageParserWorker.php
+1
-1
src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryMercurialCommitMessageParserWorker.php
+1
-1
src/applications/repository/worker/commitmessageparser/PhabricatorRepositorySvnCommitMessageParserWorker.php
+1
-1
src/applications/repository/worker/commitmessageparser/PhabricatorRepositorySvnCommitMessageParserWorker.php