@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix "Create Form" link destinations when editing edit forms
Summary:
Fixes T12301. In D17372, this changed to use generic EditEngines instead of the proper runtime engine. Normally this doesn't matter, but can in this case.
After loading the configurations normally, swap their attached engines for the specific configured runtime engine we're currently executing.
Test Plan: Clicked "Create Form" from the Maniphest form list, saw it go to "Create Maniphest Form", not "Create Generic Meta-Form".
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T12301
Differential Revision: https://secure.phabricator.com/D17398
+7
+7
src/applications/transactions/editengine/PhabricatorEditEngine.php
+7
src/applications/transactions/editengine/PhabricatorEditEngine.php
···
2126
2126
2127
2127
$configs = msort($configs, 'getCreateSortKey');
2128
2128
2129
+
// Attach this specific engine to configurations we load so they can access
2130
+
// any runtime configuration. For example, this allows us to generate the
2131
+
// correct "Create Form" buttons when editing forms, see T12301.
2132
+
foreach ($configs as $config) {
2133
+
$config->attachEngine($this);
2134
+
}
2135
+
2129
2136
return $configs;
2130
2137
}
2131
2138