@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Use PhutilProxyException to disambiguate work queue failures
Summary: Fixes T2569. This is the other common exception source which is ambiguous. List the task ID explicitly to make debugging easier.
Test Plan: {F51268}
Reviewers: btrahan
Reviewed By: btrahan
CC: aran
Maniphest Tasks: T2569
Differential Revision: https://secure.phabricator.com/D6549
+3
-1
+3
-1
src/infrastructure/daemon/workers/PhabricatorTaskmasterDaemon.php
+3
-1
src/infrastructure/daemon/workers/PhabricatorTaskmasterDaemon.php
···
23
23
$this->log("Task {$id} failed permanently.");
24
24
} else {
25
25
$this->log("Task {$id} failed!");
26
-
throw $ex;
26
+
throw new PhutilProxyException(
27
+
"Error while executing task ID {$id} from queue.",
28
+
$ex);
27
29
}
28
30
} else {
29
31
$this->log("Task {$id} complete! Moved to archive.");