recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix wrong image file dimensions in "Default Alt Text" on File pages

Summary:
Rendering a `PhutilNumber` as a `%d` cuts off digits after the first comma, while `%s` does not. See https://we.phorge.it/D26546#39386 for gory details.

Closes T16454

Test Plan: Go to http://phorge.localhost/file/, upload an image file which has more than 1000px width and/or height, look at the "Default Alt Text" value in the "File Metadata" section of the corresponding File page.

Reviewers: O1 Blessed Committers, mainframe98

Reviewed By: O1 Blessed Committers, mainframe98

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T16454

Differential Revision: https://we.phorge.it/D26683

Andre Klapper 475addd3 b1794a3a

+1 -1
+1 -1
src/applications/files/storage/PhabricatorFile.php
··· 1386 1386 1387 1387 if ($image_x && $image_y) { 1388 1388 $stats[] = pht( 1389 - "%d\xC3\x97%d px", 1389 + "%s\xC3\x97%s px", 1390 1390 new PhutilNumber($image_x), 1391 1391 new PhutilNumber($image_y)); 1392 1392 }