recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Files: Switch Default Alt Text to width×height image dimensions order

Summary:
On a File page of an image, currently the "Dimensions" in the sidebar use "width × height", while the "Default Alt Text" under "File Metadata" uses "height × width".
Use "width × height" also for the alt text for the sake of consistency.

Closes T16453

Test Plan: Upload an image file which does not have square dimensions, go to its File page, look at the pixel values under "Dimensions" and "Default Alt Text"

Reviewers: O1 Blessed Committers, mainframe98

Reviewed By: O1 Blessed Committers, mainframe98

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T16453

Differential Revision: https://we.phorge.it/D26682

Andre Klapper b1794a3a 6d98f6b3

+2 -2
+2 -2
src/applications/files/storage/PhabricatorFile.php
··· 1381 1381 1382 1382 $stats = array(); 1383 1383 1384 - $image_x = $this->getImageHeight(); 1385 - $image_y = $this->getImageWidth(); 1384 + $image_x = $this->getImageWidth(); 1385 + $image_y = $this->getImageHeight(); 1386 1386 1387 1387 if ($image_x && $image_y) { 1388 1388 $stats[] = pht(