+1 -1

src/aphront/response/AphrontResponse.php

reviewed

··· 327 327 } 328 328 329 329 if ($value instanceof PhutilSafeHTML) { 330 330 - // TODO: Javelin supports implicity conversion of '__html' objects to 330 330 + // TODO: Javelin supports implicit conversion of '__html' objects to 331 331 // JX.HTML, but only for Ajax responses, not behaviors. Just leave things 332 332 // as they are for now (where behaviors treat responses as HTML or plain 333 333 // text at their discretion).

+1 -1

src/applications/conduit/controller/PhabricatorConduitAPIController.php

reviewed

··· 37 37 // TODO: The relationship between ConduitAPIRequest and ConduitCall is a 38 38 // little odd here and could probably be improved. Specifically, the 39 39 // APIRequest is a sub-object of the Call, which does not parallel the 40 40 - // role of AphrontRequest (which is an indepenent object). 40 40 + // role of AphrontRequest (which is an independent object). 41 41 // In particular, the setUser() and getUser() existing independently on 42 42 // the Call and APIRequest is very awkward. 43 43

+1 -1

src/applications/config/check/PhabricatorDatabaseSetupCheck.php

reviewed

··· 106 106 'The "InnoDB" engine is not available in MySQL (on host "%s"). '. 107 107 'Enable InnoDB in your MySQL configuration.'. 108 108 "\n\n". 109 109 - '(If you aleady created tables, MySQL incorrectly used some other '. 109 109 + '(If you already created tables, MySQL incorrectly used some other '. 110 110 'engine to create them. You need to convert them or drop and '. 111 111 'reinitialize them.)', 112 112 $ref_key);

+1 -1

src/applications/config/option/PhabricatorMetaMTAConfigOptions.php

reviewed

··· 74 74 - If you use mailing lists, recipients may sometimes get duplicate 75 75 mail. 76 76 - Getting threading to work properly is easier, and threading settings 77 77 - can be customzied by each user. 77 77 + can be customized by each user. 78 78 - "Reply All" will never send extra mail to other users involved in the 79 79 thread. 80 80 - Required if private reply-to addresses are configured.

+1 -1

src/applications/harbormaster/xaction/build/HarbormasterBuildMessageResumeTransaction.php

reviewed

··· 99 99 throw new HarbormasterMessageException( 100 100 pht('Unable to Resume Build'), 101 101 pht( 102 102 - 'You can not resume this build beacuse it is already resuming.')); 102 102 + 'You can not resume this build because it is already resuming.')); 103 103 } 104 104 105 105 if ($build->isRestarting()) {

+1 -1

src/applications/repository/management/PhabricatorRepositoryManagementMaintenanceWorkflow.php

reviewed

··· 23 23 'name' => 'stop', 24 24 'help' => pht( 25 25 'Take repositories out of maintenance mode, returning them '. 26 26 - 'to normal serice.'), 26 26 + 'to normal service.'), 27 27 ), 28 28 array( 29 29 'name' => 'repositories',

+1 -1

src/applications/repository/worker/__tests__/PhabricatorChangeParserTestCase.php

reviewed

··· 517 517 '/dir', 518 518 null, 519 519 null, 520 520 - // TODO: This might reasonbly be considered a bug in the parser; it 520 520 + // TODO: This might reasonably be considered a bug in the parser; it 521 521 // should probably be COPY_AWAY. 522 522 DifferentialChangeType::TYPE_CHILD, 523 523 DifferentialChangeType::FILE_DIRECTORY,

+1 -1

src/applications/search/compiler/PhutilSearchQueryCompiler.php

reviewed

··· 297 297 $use_substring = true; 298 298 } else if (phutil_preg_match('/^_/', $value)) { 299 299 // See T13632. Assume users searching for any term that begins 300 300 - // with an undescore intend to perform substring search if they 300 300 + // with an underscore intend to perform substring search if they 301 301 // don't provide an explicit search function. 302 302 $use_substring = true; 303 303 }

+1 -1

src/applications/transactions/conduit/TransactionSearchConduitAPIMethod.php

reviewed

··· 21 21 record allows you to see who edited an object, when, and how their edit changed 22 22 things. 23 23 24 24 - One common reason to call this method is that you're implmenting a webhook and 24 24 + One common reason to call this method is that you're implementing a webhook and 25 25 just received a notification that an object has changed. See the Webhooks 26 26 documentation for more detailed discussion of this use case. 27 27

+1 -1

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

reviewed

··· 391 391 $new = $this->getTransactionNewValue($object, $xaction); 392 392 $xaction->setNewValue($new); 393 393 394 394 - // Apply an optional transformation to convert "external" tranaction 394 394 + // Apply an optional transformation to convert "external" transaction 395 395 // values (provided by APIs) into "internal" values. 396 396 397 397 $old = $xaction->getOldValue();

+1 -1

src/docs/contributor/database.diviner

reviewed

··· 134 134 PHIDs 135 135 ===== 136 136 137 137 - Each globally referencable object in Phorge has an associated PHID 137 137 + Each globally referenceable object in Phorge has an associated PHID 138 138 ("Phorge ID") which serves as a global identifier, similar to a GUID. 139 139 We use PHIDs for referencing data in different databases. 140 140

+1 -1

src/docs/contributor/general_coding_standards.diviner

reviewed

··· 142 142 = Documentation, Comments and Formatting = 143 143 144 144 - Prefer to remove code by deleting it over removing it by commenting it out. 145 145 - It shall live forever in source control, and can be retrieved therefrom if 145 145 + It shall live forever in source control, and can be retrieved there from if 146 146 it is ever again called upon. 147 147 - In source code, use only ASCII printable characters plus space and linefeed. 148 148 Do not use UTF-8 or other multibyte encodings.

+1 -1

src/docs/user/configuration/configuring_inbound_email.diviner

reviewed

··· 60 60 configured with `metamta.default-address`. 61 61 62 62 When a user takes an action that generates mail, Phorge sets the 63 63 - "Reply-To" addresss for the mail to that user's name and address. This means 63 63 + "Reply-To" address for the mail to that user's name and address. This means 64 64 that users can reply to email to discuss changes, but: the conversation won't 65 65 be recorded in Phorge; and users will not be able to use email commands 66 66 to take actions or make edits.

+1 -1

src/docs/user/userguide/multi_factor_auth.diviner

reviewed

··· 134 134 - **Active**: Users may add new factors. Users will be prompted to respond 135 135 to challenges from these providers when they take a sensitive action. 136 136 - **Deprecated**: Users may not add new factors, but they will still be 137 137 - asked to respond to challenges from exising factors. 137 137 + asked to respond to challenges from existing factors. 138 138 - **Disabled**: Users may not add new factors, and existing factors will 139 139 not be used. If MFA is required and a user only has disabled factors, 140 140 they will be forced to add a new factor.

+1 -1

src/docs/user/userguide/webhooks.diviner

reviewed

··· 178 178 Test requests are never retried: they execute exactly once. 179 179 180 180 Live requests are automatically retried. If your endpoint does not return a 181 181 - HTTP 2XX response, the request will be retried regularly until it suceeds. 181 181 + HTTP 2XX response, the request will be retried regularly until it succeeds. 182 182 183 183 Retries will continue until the request succeeds or is garbage collected. By 184 184 default, this is after 7 days.

+1 -1

src/infrastructure/customfield/field/PhabricatorCustomField.php

reviewed

··· 1679 1679 foreach ($map as $field_key => $field) { 1680 1680 // For now, only support overriding standard custom fields. In the 1681 1681 // future there's no technical or product reason we couldn't let you 1682 1682 - // override (some properites of) other fields like "Title", but they 1682 1682 + // override (some properties of) other fields like "Title", but they 1683 1683 // don't usually support appropriate "setX()" methods today. 1684 1684 if (!($field instanceof PhabricatorStandardCustomField)) { 1685 1685 // For fields that are proxies on top of StandardCustomField, which

+1 -1

src/infrastructure/markup/blockrule/PhutilRemarkupLiteralBlockRule.php

reviewed

··· 7 7 } 8 8 9 9 public function getMatchingLineCount(array $lines, $cursor) { 10 10 - // NOTE: We're consuming all continguous blocks of %%% literals, so this: 10 10 + // NOTE: We're consuming all contiguous blocks of %%% literals, so this: 11 11 // 12 12 // %%%a%%% 13 13 // %%%b%%%

+1 -1

src/infrastructure/markup/syntax/highlighter/xhpast/PhutilXHPASTSyntaxHighlighterFuture.php

reviewed

··· 32 32 33 33 // We perform two passes here: one using the AST to find symbols we care 34 34 // about -- particularly, class names and function names. These are used 35 35 - // in the crossreference stuff to link into Diffusion. After we've done our 35 35 + // in the cross-reference stuff to link into Diffusion. After we've done our 36 36 // AST pass, we do a followup pass on the token stream to catch all the 37 37 // simple stuff like strings and comments. 38 38

+1 -1

src/infrastructure/parser/PhutilPygmentizeParser.php

reviewed

··· 32 32 $c = $block[$ii]; 33 33 switch ($mode) { 34 34 case 'text': 35 35 - // We're in general text between tags, and just passing characers 35 35 + // We're in general text between tags, and just passing characters 36 36 // through unmodified. 37 37 if ($c == '<') { 38 38 $mode = 'tag';

+1 -1

src/view/control/AphrontTableView.php

reviewed

··· 392 392 // white-space: pre to prevent wrapping. We need to append a character 393 393 // (&nbsp; -- nonbreaking space) afterward to give the bounds div height 394 394 // (alternatively, we could hard-code the line height). This is gross but 395 395 - // it's not clear that there's a better appraoch. 395 395 + // it's not clear that there's a better approach. 396 396 397 397 return phutil_tag( 398 398 'div',