@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix project queries in Ponder
Summary: Fixes T10167. We were dropping infrastructure joins.
Test Plan: Queried for questions by project.
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T10167
Differential Revision: https://secure.phabricator.com/D15043
+3
-3
+3
-3
src/applications/ponder/query/PonderQuestionQuery.php
+3
-3
src/applications/ponder/query/PonderQuestionQuery.php
···
129
129
return $questions;
130
130
}
131
131
132
-
protected function buildJoinClauseParts(AphrontDatabaseConnection $conn_r) {
133
-
$joins = array();
132
+
protected function buildJoinClauseParts(AphrontDatabaseConnection $conn) {
133
+
$joins = parent::buildJoinClauseParts($conn);
134
134
135
135
if ($this->answererPHIDs) {
136
136
$answer_table = new PonderAnswer();
137
137
$joins[] = qsprintf(
138
-
$conn_r,
138
+
$conn,
139
139
'JOIN %T a ON a.questionID = q.id AND a.authorPHID IN (%Ls)',
140
140
$answer_table->getTableName(),
141
141
$this->answererPHIDs);