@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix download button to work on firefox
Summary: need to setTimeout on the removal from the DOM so these browsers don't freak out
Test Plan: downloaded images on firefox and safari
Reviewers: vrana, epriestley
Reviewed By: vrana
CC: aran, Korvin
Maniphest Tasks: T1896
Differential Revision: https://secure.phabricator.com/D3799
+6
-1
+6
-1
webroot/rsrc/js/application/core/behavior-lightbox-attachments.js
+6
-1
webroot/rsrc/js/application/core/behavior-lightbox-attachments.js
···
154
154
'click',
155
155
null,
156
156
function (e) {
157
-
e.prevent(); closeLightBox(e); form.submit();
157
+
e.prevent();
158
+
form.submit();
159
+
// Firefox and probably IE need this trick to work.
160
+
// Removing a form from the DOM while its submitting is
161
+
// tricky business.
162
+
setTimeout(JX.bind(null, closeLightBox, e), 0);
158
163
}
159
164
);
160
165
var downloadSpan = JX.$N('span',