@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Straighten out some stacked action removal behaviors
Summary: Fixes T12065. Some of the normal behavior of these actions got juggled when I made "Accept" and "Reject" conflict.
Test Plan:
- Added "Accept".
- Added "Reject", saw it remove "Accept".
- Added "Change Projects".
- Added "Assign/Claim".
- Removed "Assign/Claim".
- Removed "Accept".
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T12065
Differential Revision: https://secure.phabricator.com/D17143
+3
-3
+3
-3
webroot/rsrc/js/application/transactions/behavior-comment-actions.js
+3
-3
webroot/rsrc/js/application/transactions/behavior-comment-actions.js
···
146
146
var conflict_key = action.conflictKey || null;
147
147
if (conflict_key !== null) {
148
148
for (var k in action_map) {
149
-
if (k === action) {
149
+
if (k === action.key) {
150
150
continue;
151
151
}
152
152
if (action_map[k].conflictKey !== conflict_key) {
···
189
189
return;
190
190
}
191
191
192
-
remove_action(action);
192
+
remove_action(action.key);
193
193
});
194
194
195
195
rows[action.key] = {
···
200
200
201
201
JX.DOM.listen(remove, 'click', null, function(e) {
202
202
e.kill();
203
-
remove_action(action);
203
+
remove_action(action.key);
204
204
});
205
205
206
206
place_node.parentNode.insertBefore(node, place_node);