recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Convert SavedQuery / NamedQuery to text, not bytes

Summary: Ref T1191. Similar issue to D10613. This column usually has a hash exactly 12 bytes long, but sometimes stores an internal builtin query name like "open", "all", etc. It might be nice to promote those to 12-byte hashes of a consistent length eventually, but for now just make this a variable-length column.

Test Plan: Ran migration, no longer saw issues with reordering builtin saved searches.

Reviewers: btrahan

Subscribers: epriestley

Maniphest Tasks: T1191

Differential Revision: https://secure.phabricator.com/D10614

epriestley 4eb43996 f881b5dd

+2 -2
+1 -1
src/applications/search/storage/PhabricatorNamedQuery.php
··· 17 17 self::CONFIG_COLUMN_SCHEMA => array( 18 18 'engineClassName' => 'text128', 19 19 'queryName' => 'text255', 20 - 'queryKey' => 'bytes12', 20 + 'queryKey' => 'text12', 21 21 'isBuiltin' => 'bool', 22 22 'isDisabled' => 'bool', 23 23 'sequence' => 'uint32',
+1 -1
src/applications/search/storage/PhabricatorSavedQuery.php
··· 14 14 ), 15 15 self::CONFIG_COLUMN_SCHEMA => array( 16 16 'engineClassName' => 'text255', 17 - 'queryKey' => 'bytes12', 17 + 'queryKey' => 'text12', 18 18 ), 19 19 self::CONFIG_KEY_SCHEMA => array( 20 20 'key_queryKey' => array(