@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Convert DivinerLiveSymbol to text, not bytes
Summary:
Ref T1191. The `bytes` types are BINARY(...), which is fixed-length and zero-pads. These hashes are not 64 characters long, so migrating them to `binary` ends up with a bunch of zero-padding.
Instead, migrate them to `text` so we drop the zero padding. It would be vaguely nice to either introduce a `varbytes` type (ick) or change the hash size to a standard size (nicer) eventually, but this isn't very important.
Test Plan: Will adjust `secure.phabricator.com`.
Reviewers: btrahan
Subscribers: epriestley
Maniphest Tasks: T1191
Differential Revision: https://secure.phabricator.com/D10613
+2
-2
+2
-2
src/applications/diviner/storage/DivinerLiveSymbol.php
+2
-2
src/applications/diviner/storage/DivinerLiveSymbol.php
···
33
33
'name' => 'text255',
34
34
'atomIndex' => 'uint32',
35
35
'identityHash' => 'bytes12',
36
-
'graphHash' => 'bytes64?',
36
+
'graphHash' => 'text64?',
37
37
'title' => 'text?',
38
38
'titleSlugHash' => 'bytes12?',
39
39
'groupName' => 'text255?',
40
40
'summary' => 'text?',
41
41
'isDocumentable' => 'bool',
42
-
'nodeHash' => 'bytes64?',
42
+
'nodeHash' => 'text64?',
43
43
),
44
44
self::CONFIG_KEY_SCHEMA => array(
45
45
'key_phid' => null,