@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Ignore keys with trailing index on table primary key for now
Summary:
Ref T1191. We have several keys on `<x, y, id>`. When `id` is an auto-increment primary key, I believe this is exactly equivalent to a key on `<x, y>`, because the leaf nodes are implicitly sorted by `id`. We omit the implicit `id` elsewhere.
It would be nice to drop the `id` bit for consistency, but it's not doing any harm and this doesn't need to block the primary work of T1191.
Test Plan: Saw slightly fewer warnings.
Reviewers: btrahan
Reviewed By: btrahan
Subscribers: epriestley
Maniphest Tasks: T1191
Differential Revision: https://secure.phabricator.com/D10592
+17
-7
+2
-2
src/applications/config/schema/PhabricatorConfigStorageSchema.php
+2
-2
src/applications/config/schema/PhabricatorConfigStorageSchema.php
···
169
169
public static function getIssueStatus($issue) {
170
170
switch ($issue) {
171
171
case self::ISSUE_MISSING:
172
-
case self::ISSUE_SUBFAIL:
173
172
case self::ISSUE_SURPLUS:
173
+
case self::ISSUE_SUBFAIL:
174
174
return self::STATUS_FAIL;
175
175
case self::ISSUE_SUBWARN:
176
176
case self::ISSUE_COLUMNTYPE:
177
-
case self::ISSUE_KEYCOLUMNS:
178
177
case self::ISSUE_NULLABLE:
179
178
return self::STATUS_WARN;
180
179
case self::ISSUE_SUBNOTE:
···
183
182
case self::ISSUE_MISSINGKEY:
184
183
case self::ISSUE_SURPLUSKEY:
185
184
case self::ISSUE_UNIQUE:
185
+
case self::ISSUE_KEYCOLUMNS:
186
186
return self::STATUS_NOTE;
187
187
default:
188
188
throw new Exception(pht('Unknown schema issue "%s"!', $issue));
+3
-3
src/applications/nuance/storage/NuanceItem.php
+3
-3
src/applications/nuance/storage/NuanceItem.php
···
38
38
),
39
39
self::CONFIG_KEY_SCHEMA => array(
40
40
'key_source' => array(
41
-
'columns' => array('sourcePHID', 'status', 'dateNuanced'),
41
+
'columns' => array('sourcePHID', 'status', 'dateNuanced', 'id'),
42
42
),
43
43
'key_owner' => array(
44
-
'columns' => array('ownerPHID', 'status', 'dateNuanced'),
44
+
'columns' => array('ownerPHID', 'status', 'dateNuanced', 'id'),
45
45
),
46
46
'key_contacter' => array(
47
-
'columns' => array('requestorPHID', 'status', 'dateNuanced'),
47
+
'columns' => array('requestorPHID', 'status', 'dateNuanced', 'id'),
48
48
),
49
49
),
50
50
) + parent::getConfiguration();
+6
-1
src/applications/nuance/storage/NuanceQueueItem.php
+6
-1
src/applications/nuance/storage/NuanceQueueItem.php
+6
-1
src/applications/phame/storage/PhamePost.php
+6
-1
src/applications/phame/storage/PhamePost.php
···
106
106
'unique' => true,
107
107
),
108
108
'bloggerPosts' => array(
109
-
'columns' => array('bloggerPHID', 'visibility', 'datePublished'),
109
+
'columns' => array(
110
+
'bloggerPHID',
111
+
'visibility',
112
+
'datePublished',
113
+
'id',
114
+
),
110
115
),
111
116
),
112
117
) + parent::getConfiguration();