@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Add formal setup guidance warning that "feed.http-hooks" will be removed in a future version of Phabricator
Summary: Depends on D20114. This is on the way out, so make that explicitly clear.
Test Plan: Read setup issue and configuration option.
Reviewers: amckinley
Reviewed By: amckinley
Differential Revision: https://secure.phabricator.com/D20115
+31
-13
+18
src/applications/config/check/PhabricatorExtraConfigSetupCheck.php
+18
src/applications/config/check/PhabricatorExtraConfigSetupCheck.php
···
84
84
$issue->addPhabricatorConfig($key);
85
85
}
86
86
}
87
+
88
+
89
+
if (PhabricatorEnv::getEnvConfig('feed.http-hooks')) {
90
+
$this->newIssue('config.deprecated.feed.http-hooks')
91
+
->setShortName(pht('Feed Hooks Deprecated'))
92
+
->setName(pht('Migrate From "feed.http-hooks" to Webhooks'))
93
+
->addPhabricatorConfig('feed.http-hooks')
94
+
->setMessage(
95
+
pht(
96
+
'The "feed.http-hooks" option is deprecated in favor of '.
97
+
'Webhooks. This option will be removed in a future version '.
98
+
'of Phabricator.'.
99
+
"\n\n".
100
+
'You can configure Webhooks in Herald.'.
101
+
"\n\n".
102
+
'To resolve this issue, remove all URIs from "feed.http-hooks".'));
103
+
}
104
+
87
105
}
88
106
89
107
/**
+13
-13
src/applications/feed/config/PhabricatorFeedConfigOptions.php
+13
-13
src/applications/feed/config/PhabricatorFeedConfigOptions.php
···
20
20
}
21
21
22
22
public function getOptions() {
23
+
$hooks_help = $this->deformat(pht(<<<EODOC
24
+
IMPORTANT: Feed hooks are deprecated and have been replaced by Webhooks.
25
+
26
+
You can configure Webhooks in Herald. This configuration option will be removed
27
+
in a future version of Phabricator.
28
+
29
+
(This legacy option may be configured with a list of URIs; feed stories will
30
+
send to these URIs.)
31
+
EODOC
32
+
));
33
+
23
34
return array(
24
35
$this->newOption('feed.http-hooks', 'list<string>', array())
25
36
->setLocked(true)
26
-
->setSummary(pht('POST notifications of feed events.'))
27
-
->setDescription(
28
-
pht(
29
-
"If you set this to a list of HTTP URIs, when a feed story is ".
30
-
"published a task will be created for each URI that posts the ".
31
-
"story data to the URI. Daemons automagically retry failures 100 ".
32
-
"times, waiting `\$fail_count * 60s` between each subsequent ".
33
-
"failure. Be sure to keep the daemon console (`%s`) open ".
34
-
"while developing and testing your end points. You may need to".
35
-
"restart your daemons to start sending HTTP requests.\n\n".
36
-
"NOTE: URIs are not validated, the URI must return HTTP status ".
37
-
"200 within 30 seconds, and no permission checks are performed.",
38
-
'/daemon/')),
37
+
->setSummary(pht('Deprecated.'))
38
+
->setDescription($hooks_help),
39
39
);
40
40
}
41
41