@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Load buildables in DiffViewController
Summary: Fixes T9128. I missed this when converting other controllers to look in Harbormaster for lint/unit data.
Test Plan: Copy/pasted a diff successfully.
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T9128
Differential Revision: https://secure.phabricator.com/D13865
+11
+11
src/applications/differential/controller/DifferentialDiffViewController.php
+11
src/applications/differential/controller/DifferentialDiffViewController.php
···
29
29
->setURI('/D'.$diff->getRevisionID().'?id='.$diff->getID());
30
30
}
31
31
32
+
$diff_phid = $diff->getPHID();
33
+
$buildables = id(new HarbormasterBuildableQuery())
34
+
->setViewer($viewer)
35
+
->withBuildablePHIDs(array($diff_phid))
36
+
->withManualBuildables(false)
37
+
->needBuilds(true)
38
+
->needTargets(true)
39
+
->execute();
40
+
$buildables = mpull($buildables, null, 'getBuildablePHID');
41
+
$diff->attachBuildable(idx($buildables, $diff_phid));
42
+
32
43
// TODO: implement optgroup support in AphrontFormSelectControl?
33
44
$select = array();
34
45
$select[] = hsprintf('<optgroup label="%s">', pht('Create New Revision'));