@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Always reset scroll after durable column is maximized
Summary: When the durable column is re-opened, scroll user to latest message. Though later we should scroll them to the last read.
Test Plan: Minimize window, reload page, pop up window, see proper scroll position.
Reviewers: epriestley
Reviewed By: epriestley
Subscribers: Korvin
Differential Revision: https://secure.phabricator.com/D16649
+18
-13
+13
-13
resources/celerity/map.php
+13
-13
resources/celerity/map.php
···
10
10
'conpherence.pkg.css' => '5f3eb99c',
11
11
'conpherence.pkg.js' => '11f3e07e',
12
12
'core.pkg.css' => '3fa66cb3',
13
-
'core.pkg.js' => '26f1f9bf',
13
+
'core.pkg.js' => '30185d95',
14
14
'darkconsole.pkg.js' => 'e7393ebb',
15
15
'differential.pkg.css' => 'e1d704ce',
16
16
'differential.pkg.js' => '634399e9',
···
438
438
'rsrc/js/application/config/behavior-reorder-fields.js' => 'b6993408',
439
439
'rsrc/js/application/conpherence/ConpherenceThreadManager.js' => '01774ab2',
440
440
'rsrc/js/application/conpherence/behavior-drag-and-drop-photo.js' => 'cf86d16a',
441
-
'rsrc/js/application/conpherence/behavior-durable-column.js' => 'f62bfb39',
441
+
'rsrc/js/application/conpherence/behavior-durable-column.js' => 'c5238acb',
442
442
'rsrc/js/application/conpherence/behavior-menu.js' => '9eb55204',
443
443
'rsrc/js/application/conpherence/behavior-participant-pane.js' => '8604caa8',
444
444
'rsrc/js/application/conpherence/behavior-pontificate.js' => 'f2e58483',
···
699
699
'javelin-behavior-diffusion-pull-lastmodified' => 'f01586dc',
700
700
'javelin-behavior-doorkeeper-tag' => 'e5822781',
701
701
'javelin-behavior-drydock-live-operation-status' => '901935ef',
702
-
'javelin-behavior-durable-column' => 'f62bfb39',
702
+
'javelin-behavior-durable-column' => 'c5238acb',
703
703
'javelin-behavior-editengine-reorder-configs' => 'd7a74243',
704
704
'javelin-behavior-editengine-reorder-fields' => 'b59e1e96',
705
705
'javelin-behavior-error-log' => '6882e80a',
···
1963
1963
'javelin-install',
1964
1964
'javelin-dom',
1965
1965
),
1966
+
'c5238acb' => array(
1967
+
'javelin-behavior',
1968
+
'javelin-dom',
1969
+
'javelin-stratcom',
1970
+
'javelin-behavior-device',
1971
+
'javelin-scrollbar',
1972
+
'javelin-quicksand',
1973
+
'phabricator-keyboard-shortcut',
1974
+
'conpherence-thread-manager',
1975
+
),
1966
1976
'c587b80f' => array(
1967
1977
'javelin-install',
1968
1978
),
···
2205
2215
'javelin-dom',
2206
2216
'javelin-request',
2207
2217
'phabricator-keyboard-shortcut',
2208
-
),
2209
-
'f62bfb39' => array(
2210
-
'javelin-behavior',
2211
-
'javelin-dom',
2212
-
'javelin-stratcom',
2213
-
'javelin-behavior-device',
2214
-
'javelin-scrollbar',
2215
-
'javelin-quicksand',
2216
-
'phabricator-keyboard-shortcut',
2217
-
'conpherence-thread-manager',
2218
2218
),
2219
2219
'f6555212' => array(
2220
2220
'javelin-install',
+5
webroot/rsrc/js/application/conpherence/behavior-durable-column.js
+5
webroot/rsrc/js/application/conpherence/behavior-durable-column.js
···
66
66
JX.DOM.alterClass(document.body, 'minimize-column', userMinimize);
67
67
JX.Stratcom.invoke('resize');
68
68
69
+
if (!userMinimize) {
70
+
var messages = _getColumnMessagesNode();
71
+
scrollbar.scrollTo(messages.scrollHeight);
72
+
}
73
+
69
74
new JX.Request(config.minimizeURI)
70
75
.setData({value: (userMinimize ? 1 : 0)})
71
76
.send();