recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix issue where accessing HTTP domain would override HTTPS cookie

Summary: This fixes an issue where visiting http://code.redpointsoftware.com.au/ would log you out of https://code.redpointsoftware.com.au/

Test Plan: Applied this patch to a live server and saw the issue go away.

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley

CC: Korvin, epriestley, aran

Differential Revision: https://secure.phabricator.com/D8244

James Rhodes 569a5be5 34fae7e3

+5
+5
src/aphront/AphrontRequest.php
··· 305 305 * @task cookie 306 306 */ 307 307 private function getCookieDomainURI() { 308 + if (PhabricatorEnv::getEnvConfig('security.require-https') && 309 + !$this->isHTTPS()) { 310 + return null; 311 + } 312 + 308 313 $host = $this->getHost(); 309 314 310 315 // If there's no base domain configured, just use whatever the request