@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Clean up some card issues

Summary:
Ref T2826.

- Adds a min height (arbitrarily, height of the gradient; other choices are 60px [title + avatar], or 70px [title + projects + closed + avatar]).
- Color bars 4px -> 6px.
- Fixes profile image clipping in Firefox, etc.
- Removes background color from avatars, for transparent GIFs and such.
- Fixes shift-click to select tasks in views that can't be grabbed.

Test Plan: {F37535}

Reviewers: chad

Reviewed By: chad

CC: aran

Maniphest Tasks: T2826

Differential Revision: https://secure.phabricator.com/D5436

+48 -42
+39 -39
src/__celerity_resource_map__.php
··· 2996 2996 ), 2997 2997 'phabricator-object-item-list-view-css' => 2998 2998 array( 2999 - 'uri' => '/res/527ed374/rsrc/css/layout/phabricator-object-item-list-view.css', 2999 + 'uri' => '/res/c5d7eb5b/rsrc/css/layout/phabricator-object-item-list-view.css', 3000 3000 'type' => 'css', 3001 3001 'requires' => 3002 3002 array( ··· 3694 3694 ), array( 3695 3695 'packages' => 3696 3696 array( 3697 - '2f159460' => 3697 + '5d5de6ec' => 3698 3698 array( 3699 3699 'name' => 'core.pkg.css', 3700 3700 'symbols' => ··· 3736 3736 34 => 'phabricator-object-item-list-view-css', 3737 3737 35 => 'global-drag-and-drop-css', 3738 3738 ), 3739 - 'uri' => '/res/pkg/2f159460/core.pkg.css', 3739 + 'uri' => '/res/pkg/5d5de6ec/core.pkg.css', 3740 3740 'type' => 'css', 3741 3741 ), 3742 3742 '95ceba95' => ··· 3927 3927 'reverse' => 3928 3928 array( 3929 3929 'aphront-attached-file-view-css' => '6b1fccc6', 3930 - 'aphront-dialog-view-css' => '2f159460', 3931 - 'aphront-error-view-css' => '2f159460', 3932 - 'aphront-form-view-css' => '2f159460', 3933 - 'aphront-list-filter-view-css' => '2f159460', 3934 - 'aphront-pager-view-css' => '2f159460', 3935 - 'aphront-panel-view-css' => '2f159460', 3936 - 'aphront-table-view-css' => '2f159460', 3937 - 'aphront-tokenizer-control-css' => '2f159460', 3938 - 'aphront-tooltip-css' => '2f159460', 3939 - 'aphront-typeahead-control-css' => '2f159460', 3930 + 'aphront-dialog-view-css' => '5d5de6ec', 3931 + 'aphront-error-view-css' => '5d5de6ec', 3932 + 'aphront-form-view-css' => '5d5de6ec', 3933 + 'aphront-list-filter-view-css' => '5d5de6ec', 3934 + 'aphront-pager-view-css' => '5d5de6ec', 3935 + 'aphront-panel-view-css' => '5d5de6ec', 3936 + 'aphront-table-view-css' => '5d5de6ec', 3937 + 'aphront-tokenizer-control-css' => '5d5de6ec', 3938 + 'aphront-tooltip-css' => '5d5de6ec', 3939 + 'aphront-typeahead-control-css' => '5d5de6ec', 3940 3940 'differential-changeset-view-css' => '8aaacd1b', 3941 3941 'differential-core-view-css' => '8aaacd1b', 3942 3942 'differential-inline-comment-editor' => '322728f3', ··· 3950 3950 'differential-table-of-contents-css' => '8aaacd1b', 3951 3951 'diffusion-commit-view-css' => 'c8ce2d88', 3952 3952 'diffusion-icons-css' => 'c8ce2d88', 3953 - 'global-drag-and-drop-css' => '2f159460', 3953 + 'global-drag-and-drop-css' => '5d5de6ec', 3954 3954 'inline-comment-summary-css' => '8aaacd1b', 3955 3955 'javelin-aphlict' => '95ceba95', 3956 3956 'javelin-behavior' => 'fe22443b', ··· 4022 4022 'javelin-util' => 'fe22443b', 4023 4023 'javelin-vector' => 'fe22443b', 4024 4024 'javelin-workflow' => 'fe22443b', 4025 - 'lightbox-attachment-css' => '2f159460', 4025 + 'lightbox-attachment-css' => '5d5de6ec', 4026 4026 'maniphest-task-summary-css' => '6b1fccc6', 4027 4027 'maniphest-transaction-detail-css' => '6b1fccc6', 4028 4028 'phabricator-busy' => '95ceba95', 4029 4029 'phabricator-content-source-view-css' => '8aaacd1b', 4030 - 'phabricator-core-buttons-css' => '2f159460', 4031 - 'phabricator-core-css' => '2f159460', 4032 - 'phabricator-crumbs-view-css' => '2f159460', 4033 - 'phabricator-directory-css' => '2f159460', 4030 + 'phabricator-core-buttons-css' => '5d5de6ec', 4031 + 'phabricator-core-css' => '5d5de6ec', 4032 + 'phabricator-crumbs-view-css' => '5d5de6ec', 4033 + 'phabricator-directory-css' => '5d5de6ec', 4034 4034 'phabricator-drag-and-drop-file-upload' => '322728f3', 4035 4035 'phabricator-dropdown-menu' => '95ceba95', 4036 4036 'phabricator-file-upload' => '95ceba95', 4037 - 'phabricator-filetree-view-css' => '2f159460', 4038 - 'phabricator-flag-css' => '2f159460', 4039 - 'phabricator-form-view-css' => '2f159460', 4040 - 'phabricator-header-view-css' => '2f159460', 4041 - 'phabricator-jump-nav' => '2f159460', 4037 + 'phabricator-filetree-view-css' => '5d5de6ec', 4038 + 'phabricator-flag-css' => '5d5de6ec', 4039 + 'phabricator-form-view-css' => '5d5de6ec', 4040 + 'phabricator-header-view-css' => '5d5de6ec', 4041 + 'phabricator-jump-nav' => '5d5de6ec', 4042 4042 'phabricator-keyboard-shortcut' => '95ceba95', 4043 4043 'phabricator-keyboard-shortcut-manager' => '95ceba95', 4044 - 'phabricator-main-menu-view' => '2f159460', 4044 + 'phabricator-main-menu-view' => '5d5de6ec', 4045 4045 'phabricator-menu-item' => '95ceba95', 4046 - 'phabricator-nav-view-css' => '2f159460', 4046 + 'phabricator-nav-view-css' => '5d5de6ec', 4047 4047 'phabricator-notification' => '95ceba95', 4048 - 'phabricator-notification-css' => '2f159460', 4049 - 'phabricator-notification-menu-css' => '2f159460', 4050 - 'phabricator-object-item-list-view-css' => '2f159460', 4048 + 'phabricator-notification-css' => '5d5de6ec', 4049 + 'phabricator-notification-menu-css' => '5d5de6ec', 4050 + 'phabricator-object-item-list-view-css' => '5d5de6ec', 4051 4051 'phabricator-object-selector-css' => '8aaacd1b', 4052 4052 'phabricator-paste-file-upload' => '95ceba95', 4053 4053 'phabricator-prefab' => '95ceba95', 4054 4054 'phabricator-project-tag-css' => '6b1fccc6', 4055 - 'phabricator-remarkup-css' => '2f159460', 4055 + 'phabricator-remarkup-css' => '5d5de6ec', 4056 4056 'phabricator-shaped-request' => '322728f3', 4057 - 'phabricator-side-menu-view-css' => '2f159460', 4058 - 'phabricator-standard-page-view' => '2f159460', 4057 + 'phabricator-side-menu-view-css' => '5d5de6ec', 4058 + 'phabricator-standard-page-view' => '5d5de6ec', 4059 4059 'phabricator-textareautils' => '95ceba95', 4060 4060 'phabricator-tooltip' => '95ceba95', 4061 - 'phabricator-transaction-view-css' => '2f159460', 4062 - 'phabricator-zindex-css' => '2f159460', 4063 - 'sprite-apps-large-css' => '2f159460', 4064 - 'sprite-gradient-css' => '2f159460', 4065 - 'sprite-icon-css' => '2f159460', 4066 - 'sprite-menu-css' => '2f159460', 4067 - 'syntax-highlighting-css' => '2f159460', 4061 + 'phabricator-transaction-view-css' => '5d5de6ec', 4062 + 'phabricator-zindex-css' => '5d5de6ec', 4063 + 'sprite-apps-large-css' => '5d5de6ec', 4064 + 'sprite-gradient-css' => '5d5de6ec', 4065 + 'sprite-icon-css' => '5d5de6ec', 4066 + 'sprite-menu-css' => '5d5de6ec', 4067 + 'syntax-highlighting-css' => '5d5de6ec', 4068 4068 ), 4069 4069 ));
+2
src/applications/maniphest/view/ManiphestTaskListView.php
··· 79 79 80 80 if ($this->showSubpriorityControls) { 81 81 $item->setGrippable(true); 82 + } 83 + if ($this->showSubpriorityControls || $this->showBatchControls) { 82 84 $item->addSigil('maniphest-task'); 83 85 } 84 86
+1 -1
src/view/layout/PhabricatorObjectItemView.php
··· 373 373 374 374 $options = array( 375 375 'class' => 'phabricator-object-item-handle-icon', 376 - 'style' => 'background: url('.$handle->getImageURI().')', 376 + 'style' => 'background-image: url('.$handle->getImageURI().')', 377 377 ); 378 378 379 379 if (strlen($label)) {
+6 -2
webroot/rsrc/css/layout/phabricator-object-item-list-view.css
··· 326 326 width: 28px; 327 327 height: 28px; 328 328 display: inline-block; 329 - background: #f3f3f3; 330 329 background-size: 28px 28px; 331 330 background-repeat: no-repeat; 332 331 } ··· 341 340 /* Hard to sprite since we can't have other sprites appearing in tall cells */ 342 341 .phabricator-object-list-cards .phabricator-object-item { 343 342 border-radius: 3px; 344 - border-left-width: 4px; 343 + border-left-width: 6px; 345 344 background: #e8e8e8 url('/rsrc/image/texture/card-gradient.png') repeat-x; 346 345 } 346 + 347 + .phabricator-object-list-cards .phabricator-object-item-frame { 348 + min-height: 47px; 349 + } 350 + 347 351 348 352 .phabricator-object-list-cards .phabricator-object-item-name { 349 353 font-size: 13px;