recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix an issue where known Subversion commits are incorrectly shown as "Discovering..."

Summary:
Ref T13552. The behavior of "RepositoryQuery" with ambiguous identifiers under "withRepositoryPHIDs()" is tricky. This leads to failure to load commits in Subversion in some cases.

Use "withRepository()", which gives us the correct identifier resolution behavior.

Test Plan: Viewed a subversion repository history in Diffusion, saw commit details after change.

Maniphest Tasks: T13552

Differential Revision: https://secure.phabricator.com/D21469

epriestley 58d3f614 f21a00a3

+1 -1
+1 -1
src/applications/diffusion/view/DiffusionCommitGraphView.php
··· 614 614 615 615 $commits = id(new DiffusionCommitQuery()) 616 616 ->setViewer($viewer) 617 - ->withRepositoryPHIDs(array($repository->getPHID())) 617 + ->withRepository($repository) 618 618 ->withIdentifiers($identifiers) 619 619 ->needCommitData(true) 620 620 ->needIdentities(true)