@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Refine handling of "@task" attributes in Diviner
Summary: Ref T13505. See that task for details. When a class has exactly one "@task" block, this API returns a string. Some day, this should be made more consistent.
Test Plan: Viewed a class with exactly one "@task", no more fatal. Viewed classes with zero and more than one "@task" attributes, got clean renderings.
Maniphest Tasks: T13505
Differential Revision: https://secure.phabricator.com/D21062
+9
+9
src/applications/diviner/controller/DivinerAtomController.php
+9
src/applications/diviner/controller/DivinerAtomController.php
···
435
435
$task_specs = array();
436
436
437
437
$tasks = $symbol->getAtom()->getDocblockMetaValue('task');
438
+
439
+
if (!is_array($tasks)) {
440
+
if (strlen($tasks)) {
441
+
$tasks = array($tasks);
442
+
} else {
443
+
$tasks = array();
444
+
}
445
+
}
446
+
438
447
if ($tasks) {
439
448
foreach ($tasks as $task) {
440
449
list($name, $title) = explode(' ', $task, 2);