@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Move PhabricatorModularTransaction slightly closer to having "final" methods again
Summary: Depends on D19290. Ref T13110. Differential still has some hacks in place which require these methods to "very temporarily" be nonfinal, but the badness can be slightly reduced nowadays.
Test Plan: Loaded some pages, nothing fataled.
Maniphest Tasks: T13110
Differential Revision: https://secure.phabricator.com/D19291
+2
-2
+2
-2
src/applications/transactions/storage/PhabricatorModularTransaction.php
+2
-2
src/applications/transactions/storage/PhabricatorModularTransaction.php
···
176
176
return parent::attachViewer($viewer);
177
177
}
178
178
179
-
/* final */ public function hasChangeDetails() {
179
+
final public function hasChangeDetails() {
180
180
if ($this->getTransactionImplementation()->hasChangeDetailView()) {
181
181
return true;
182
182
}
···
184
184
return parent::hasChangeDetails();
185
185
}
186
186
187
-
/* final */ public function renderChangeDetails(PhabricatorUser $viewer) {
187
+
final public function renderChangeDetails(PhabricatorUser $viewer) {
188
188
$impl = $this->getTransactionImplementation();
189
189
$impl->setViewer($viewer);
190
190
$view = $impl->newChangeDetailView();