@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Remove ReleephEvent
Summary:
Ref T3663. This is a proto-transaction record which is obsoleted by real transactions. It has no UI, so I'm not bothering to retain/migrate the data since there's no regression.
Just get rid of it and all its writers. I'm keeping the table for now in case something crazy uses this somehow, so no data is actually destroyed.
Test Plan: `grep`
Reviewers: btrahan
Reviewed By: btrahan
CC: aran
Maniphest Tasks: T3663
Differential Revision: https://secure.phabricator.com/D6784
-59
-2
src/__phutil_library_map__.php
-2
src/__phutil_library_map__.php
···
1960
1960
'ReleephDiffMessageFieldSpecification' => 'applications/releeph/field/specification/ReleephDiffMessageFieldSpecification.php',
1961
1961
'ReleephDiffSizeFieldSpecification' => 'applications/releeph/field/specification/ReleephDiffSizeFieldSpecification.php',
1962
1962
'ReleephDifferentialRevisionDetailRenderer' => 'applications/releeph/differential/ReleephDifferentialRevisionDetailRenderer.php',
1963
-
'ReleephEvent' => 'applications/releeph/storage/event/ReleephEvent.php',
1964
1963
'ReleephFieldParseException' => 'applications/releeph/field/exception/ReleephFieldParseException.php',
1965
1964
'ReleephFieldSelector' => 'applications/releeph/field/selector/ReleephFieldSelector.php',
1966
1965
'ReleephFieldSpecification' => 'applications/releeph/field/specification/ReleephFieldSpecification.php',
···
4140
4139
'ReleephDiffChurnFieldSpecification' => 'ReleephFieldSpecification',
4141
4140
'ReleephDiffMessageFieldSpecification' => 'ReleephFieldSpecification',
4142
4141
'ReleephDiffSizeFieldSpecification' => 'ReleephFieldSpecification',
4143
-
'ReleephEvent' => 'ReleephDAO',
4144
4142
'ReleephFieldParseException' => 'Exception',
4145
4143
'ReleephFieldSpecification' =>
4146
4144
array(
-18
src/applications/releeph/editor/ReleephBranchEditor.php
-18
src/applications/releeph/editor/ReleephBranchEditor.php
···
71
71
->save();
72
72
}
73
73
74
-
id(new ReleephEvent())
75
-
->setType(ReleephEvent::TYPE_BRANCH_CREATE)
76
-
->setActorPHID($this->requireActor()->getPHID())
77
-
->setReleephProjectID($this->releephProject->getID())
78
-
->setReleephBranchID($branch->getID())
79
-
->save();
80
-
81
74
$table->saveTransaction();
82
75
return $branch;
83
76
}
···
85
78
// aka "close" and "reopen"
86
79
public function changeBranchAccess($is_active) {
87
80
$branch = $this->releephBranch;
88
-
$branch->openTransaction();
89
81
90
82
$branch
91
83
->setIsActive((int)$is_active)
92
84
->save();
93
-
94
-
id(new ReleephEvent())
95
-
->setType(ReleephEvent::TYPE_BRANCH_ACCESS)
96
-
->setActorPHID($this->requireActor()->getPHID())
97
-
->setReleephProjectID($branch->getReleephProjectID())
98
-
->setReleephBranchID($branch->getID())
99
-
->setDetail('isActive', $is_active)
100
-
->save();
101
-
102
-
$branch->saveTransaction();
103
85
}
104
86
105
87
}
-39
src/applications/releeph/storage/event/ReleephEvent.php
-39
src/applications/releeph/storage/event/ReleephEvent.php
···
1
-
<?php
2
-
3
-
final class ReleephEvent extends ReleephDAO {
4
-
5
-
const TYPE_BRANCH_CREATE = 'branch-create';
6
-
const TYPE_BRANCH_ACCESS = 'branch-access-change';
7
-
8
-
protected $releephProjectID;
9
-
protected $releephBranchID;
10
-
protected $type;
11
-
protected $epoch;
12
-
protected $actorPHID;
13
-
protected $details = array();
14
-
15
-
public function getConfiguration() {
16
-
return array(
17
-
self::CONFIG_SERIALIZATION => array(
18
-
'details' => self::SERIALIZATION_JSON,
19
-
),
20
-
) + parent::getConfiguration();
21
-
}
22
-
23
-
public function getDetail($key, $default = null) {
24
-
return idx($this->details, $key, $default);
25
-
}
26
-
27
-
public function setDetail($key, $value) {
28
-
$this->details[$key] = $value;
29
-
return $this;
30
-
}
31
-
32
-
protected function willSaveObject() {
33
-
parent::willSaveObject();
34
-
if (!$this->epoch) {
35
-
$this->epoch = $this->dateCreated;
36
-
}
37
-
}
38
-
39
-
}