@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Update Meta for new UI
Summary: Runs through Meta, cleaned up policies and editing email addresses to new UI
Test Plan: Set a new Email address for Maniphest, edit policies.
Reviewers: epriestley
Reviewed By: epriestley
Subscribers: Korvin
Differential Revision: https://secure.phabricator.com/D15569
+38
-30
+1
-2
src/applications/meta/controller/PhabricatorApplicationDetailViewController.php
+1
-2
src/applications/meta/controller/PhabricatorApplicationDetailViewController.php
···
123
123
PhabricatorApplication $application) {
124
124
125
125
$viewer = $this->getViewer();
126
-
$properties = id(new PHUIPropertyListView())
127
-
->setStacked(true);
126
+
$properties = id(new PHUIPropertyListView());
128
127
129
128
$header = id(new PHUIHeaderView())
130
129
->setHeader(pht('POLICIES'))
+13
-8
src/applications/meta/controller/PhabricatorApplicationEditController.php
+13
-8
src/applications/meta/controller/PhabricatorApplicationEditController.php
···
171
171
$crumbs = $this->buildApplicationCrumbs();
172
172
$crumbs->addTextCrumb($application->getName(), $view_uri);
173
173
$crumbs->addTextCrumb(pht('Edit Policies'));
174
+
$crumbs->setBorder(true);
174
175
175
176
$header = id(new PHUIHeaderView())
176
-
->setHeader(pht('Edit Policies: %s', $application->getName()));
177
+
->setHeader(pht('Edit Policies: %s', $application->getName()))
178
+
->setHeaderIcon('fa-pencil');
177
179
178
180
$object_box = id(new PHUIObjectBoxView())
179
-
->setHeader($header)
181
+
->setHeaderText(pht('Policies'))
182
+
->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
180
183
->setForm($form);
181
184
182
-
return $this->buildApplicationPage(
183
-
array(
184
-
$crumbs,
185
+
$view = id(new PHUITwoColumnView())
186
+
->setHeader($header)
187
+
->setFooter(array(
185
188
$object_box,
186
-
),
187
-
array(
188
-
'title' => $title,
189
189
));
190
+
191
+
return $this->newPage()
192
+
->setTitle($title)
193
+
->setCrumbs($crumbs)
194
+
->appendChild($view);
190
195
}
191
196
192
197
}
+4
-8
src/applications/meta/controller/PhabricatorApplicationEmailCommandsController.php
+4
-8
src/applications/meta/controller/PhabricatorApplicationEmailCommandsController.php
···
137
137
->appendChild($info_view)
138
138
->appendChild($content_box);
139
139
140
-
return $this->buildApplicationPage(
141
-
array(
142
-
$crumbs,
143
-
$document,
144
-
),
145
-
array(
146
-
'title' => $title,
147
-
));
140
+
return $this->newPage()
141
+
->setTitle($title)
142
+
->setCrumbs($crumbs)
143
+
->appendChild($document);
148
144
149
145
}
150
146
+8
-3
src/applications/meta/controller/PhabricatorApplicationPanelController.php
+8
-3
src/applications/meta/controller/PhabricatorApplicationPanelController.php
···
59
59
60
60
public function buildPanelPage(
61
61
PhabricatorApplicationConfigurationPanel $panel,
62
-
$content,
63
-
array $options) {
64
-
return $this->buildApplicationPage($content, $options);
62
+
$title,
63
+
$crumbs,
64
+
$content) {
65
+
66
+
return $this->newPage()
67
+
->setTitle($title)
68
+
->setCrumbs($crumbs)
69
+
->appendChild($content);
65
70
}
66
71
67
72
}
+12
-9
src/applications/metamta/applicationpanel/PhabricatorMetaMTAApplicationEmailPanel.php
+12
-9
src/applications/metamta/applicationpanel/PhabricatorMetaMTAApplicationEmailPanel.php
···
37
37
38
38
$box = id(new PHUIObjectBoxView())
39
39
->setHeader($header)
40
+
->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
40
41
->setTable($table);
41
42
42
43
return $box;
···
81
82
82
83
$crumbs = $controller->buildPanelCrumbs($this);
83
84
$crumbs->addTextCrumb(pht('Edit Application Emails'));
85
+
$crumbs->setBorder(true);
84
86
85
87
$header = id(new PHUIHeaderView())
86
88
->setHeader(pht('Edit Application Emails: %s', $application->getName()))
87
-
->setSubheader($application->getAppEmailBlurb());
89
+
->setSubheader($application->getAppEmailBlurb())
90
+
->setHeaderIcon('fa-pencil');
88
91
89
92
$icon = id(new PHUIIconView())
90
93
->setIcon('fa-plus');
···
97
100
$header->addActionLink($button);
98
101
99
102
$object_box = id(new PHUIObjectBoxView())
100
-
->setHeader($header)
103
+
->setHeaderText(pht('Emails'))
104
+
->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
101
105
->setTable($table);
102
106
103
107
$title = $application->getName();
108
+
$view = id(new PHUITwoColumnView())
109
+
->setHeader($header)
110
+
->setFooter($object_box);
104
111
105
112
return $controller->buildPanelPage(
106
113
$this,
107
-
array(
108
-
$crumbs,
109
-
$object_box,
110
-
),
111
-
array(
112
-
'title' => $title,
113
-
));
114
+
$title,
115
+
$crumbs,
116
+
$view);
114
117
}
115
118
116
119
private function returnNewAddressResponse(