@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Remove "DifferentialGitSVNIDField" custom field in Differential
Summary: Ref T11114. This is obsolted by the narrower `DifferentialGitSVNIDCommitMessageField`.
Test Plan: Browsed around.
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T11114
Differential Revision: https://secure.phabricator.com/D17075
-47
-2
src/__phutil_library_map__.php
-2
src/__phutil_library_map__.php
···
445
445
'DifferentialGetWorkingCopy' => 'applications/differential/DifferentialGetWorkingCopy.php',
446
446
'DifferentialGitHubLandingStrategy' => 'applications/differential/landing/DifferentialGitHubLandingStrategy.php',
447
447
'DifferentialGitSVNIDCommitMessageField' => 'applications/differential/field/DifferentialGitSVNIDCommitMessageField.php',
448
-
'DifferentialGitSVNIDField' => 'applications/differential/customfield/DifferentialGitSVNIDField.php',
449
448
'DifferentialHarbormasterField' => 'applications/differential/customfield/DifferentialHarbormasterField.php',
450
449
'DifferentialHiddenComment' => 'applications/differential/storage/DifferentialHiddenComment.php',
451
450
'DifferentialHostField' => 'applications/differential/customfield/DifferentialHostField.php',
···
5095
5094
'DifferentialGetWorkingCopy' => 'Phobject',
5096
5095
'DifferentialGitHubLandingStrategy' => 'DifferentialLandingStrategy',
5097
5096
'DifferentialGitSVNIDCommitMessageField' => 'DifferentialCommitMessageField',
5098
-
'DifferentialGitSVNIDField' => 'DifferentialCustomField',
5099
5097
'DifferentialHarbormasterField' => 'DifferentialCustomField',
5100
5098
'DifferentialHiddenComment' => 'DifferentialDAO',
5101
5099
'DifferentialHostField' => 'DifferentialCustomField',
-45
src/applications/differential/customfield/DifferentialGitSVNIDField.php
-45
src/applications/differential/customfield/DifferentialGitSVNIDField.php
···
1
-
<?php
2
-
3
-
/**
4
-
* This field doesn't do anything, it just parses the "git-svn-id" field which
5
-
* `git svn` inserts into commit messages so that we don't end up mangling
6
-
* some other field.
7
-
*/
8
-
final class DifferentialGitSVNIDField
9
-
extends DifferentialCustomField {
10
-
11
-
public function getFieldKey() {
12
-
return 'differential:git-svn-id';
13
-
}
14
-
15
-
public function getFieldKeyForConduit() {
16
-
return 'gitSVNID';
17
-
}
18
-
19
-
public function getFieldName() {
20
-
return pht('git-svn-id');
21
-
}
22
-
23
-
public function getFieldDescription() {
24
-
return pht(
25
-
'Parses the "%s" field which Git/SVN can inject into commit messages.',
26
-
'git-svn-id');
27
-
}
28
-
29
-
public function canDisableField() {
30
-
return false;
31
-
}
32
-
33
-
public function shouldAppearInCommitMessage() {
34
-
return true;
35
-
}
36
-
37
-
public function shouldAllowEditInCommitMessage() {
38
-
return false;
39
-
}
40
-
41
-
public function renderCommitMessageValue(array $handles) {
42
-
return null;
43
-
}
44
-
45
-
}