recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Check for null, strictly, in maniphest.update param validation

Summary:
If the first non-null entry in the params array is falsey, the request bombs.

Something like {"id":279,"projectPHIDs":[],"status":"0","ownerPHID":"PHID-USER-on3xxsnaljmfn36d4b7a"}

Test Plan:
Before:

echo '{"id":279,"projectPHIDs":[],"status":"0","ownerPHID":"PHID-USER-cj3cpuh7oorbmnn2pl5g"}' | arc call-conduit maniphest.update
{"error":"ERR-NO-EFFECT","errorMessage":"ERR-NO-EFFECT: Update has no effect.","response":null}

After:

echo '{"id":279,"projectPHIDs":[],"status":"0","ownerPHID":"PHID-USER-cj3cpuh7oorbmnn2pl5g"}' | arc call-conduit maniphest.update
{"error":null,"errorMessage":null,"response":{"id":"279","phid":"PHID-TASK-lbwcq3pmur2c5fuqqhlx"...

Reviewers: garoevans, epriestley, #blessed_reviewers

Reviewed By: epriestley

CC: Korvin, epriestley, aran

Differential Revision: https://secure.phabricator.com/D8391

authored by

Alex Wyler and committed by
epriestley 5fabda2a fb87d0f4

+1 -2
+1 -2
src/applications/maniphest/conduit/ConduitAPI_maniphest_update_Method.php
··· 49 49 $params = $request->getAllParameters(); 50 50 unset($params['id']); 51 51 unset($params['phid']); 52 - $params = call_user_func_array('coalesce', $params); 53 52 54 - if (!$params) { 53 + if (call_user_func_array('coalesce', $params) === null) { 55 54 throw new ConduitException('ERR-NO-EFFECT'); 56 55 } 57 56