recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Only index documentable atoms for search

Summary: Ref T7458. Only index documentable atoms in the search index. In particular, this prevents files and methods from being returned in search results (clicking on these search results doesn't actually work anyway).

Test Plan: Actually, to get this to work I had to destroy the search index and recreate it... is this expected?

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: epriestley, Korvin

Maniphest Tasks: T7458

Differential Revision: https://secure.phabricator.com/D13298

Joshua Spence 600a3e3b a1561a4d

+4
+4
src/applications/diviner/search/DivinerAtomSearchIndexer.php
··· 10 10 $atom = $this->loadDocumentByPHID($phid); 11 11 $book = $atom->getBook(); 12 12 13 + if (!$atom->getIsDocumentable()) { 14 + return null; 15 + } 16 + 13 17 $doc = $this->newDocument($phid) 14 18 ->setDocumentTitle($atom->getTitle()) 15 19 ->setDocumentCreated($book->getDateCreated())