recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix a fatal in Diviner when atoms extend ghosts

Summary:
Fixes T8547. I wasn't immediately able to reproduce this locally (although I didn't try too hard), but I think the issue is that when atoms extend ghosts (probably they are usually ghosts themselves?), we try to check the ghost language and fatal.

Instead, don't match ghosts when figuring out what an atom extends.

This could maybe be a little cleaner (match the ghosts, at lower priority, and show that they're ghosts?) but I'm not sure there's a real product use case for it, and this looks like a safer way to stop the bleeding for now.

Test Plan: Poked around Diviner locally.

Reviewers: joshuaspence

Reviewed By: joshuaspence

Subscribers: epriestley

Maniphest Tasks: T8547

Differential Revision: https://secure.phabricator.com/D13300

epriestley a1561a4d 9f1235d8

+1
+1
src/applications/diviner/query/DivinerAtomQuery.php
··· 179 179 $xatoms = id(new DivinerAtomQuery()) 180 180 ->setViewer($this->getViewer()) 181 181 ->withNames($names) 182 + ->withGhosts(false) 182 183 ->needExtends(true) 183 184 ->needAtoms(true) 184 185 ->needChildren($this->needChildren)