@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Use binary_safe_diff from arcanist
Summary:
binary_safe_diff is needed in arcanist too. Moved it over to
arcanist. See D2915.
Test Plan: diffusion page rendered correctly on binary file.
Reviewers: epriestley
Reviewed By: epriestley
CC: aran, Korvin
Differential Revision: https://secure.phabricator.com/D2916
+2
-8
-6
scripts/repository/binary_safe_diff.sh
-6
scripts/repository/binary_safe_diff.sh
+2
-2
src/applications/diffusion/query/rawdiff/DiffusionSvnRawDiffQuery.php
+2
-2
src/applications/diffusion/query/rawdiff/DiffusionSvnRawDiffQuery.php
···
23
23
$repository = $drequest->getRepository();
24
24
25
25
$commit = $drequest->getCommit();
26
-
$root = phutil_get_library_root('phabricator');
26
+
$arc_root = phutil_get_library_root('arcanist');
27
27
28
28
$future = $repository->getRemoteCommandFuture(
29
29
'diff --diff-cmd %s -x -U%d -c %d %s%s@',
30
-
$root.'/../scripts/repository/binary_safe_diff.sh',
30
+
$arc_root.'/../scripts/repository/binary_safe_diff.sh',
31
31
$this->getLinesOfContext(),
32
32
$commit,
33
33
$repository->getRemoteURI(),