@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Allow device bindings to be destroyed
Summary: Ref T9762. Currently it is not possible to destroy an Alamanac device because any associate bindings cannot be destroyed.
Test Plan: Destroyed an Almanac device.
Reviewers: #blessed_reviewers, epriestley
Reviewed By: #blessed_reviewers, epriestley
Subscribers: Korvin
Maniphest Tasks: T9762
Differential Revision: https://secure.phabricator.com/D14461
+13
-1
+1
src/__phutil_library_map__.php
+1
src/__phutil_library_map__.php
···
3755
3755
'PhabricatorCustomFieldInterface',
3756
3756
'PhabricatorApplicationTransactionInterface',
3757
3757
'AlmanacPropertyInterface',
3758
+
'PhabricatorDestructibleInterface',
3758
3759
),
3759
3760
'AlmanacBindingEditController' => 'AlmanacServiceController',
3760
3761
'AlmanacBindingEditor' => 'PhabricatorApplicationTransactionEditor',
+12
-1
src/applications/almanac/storage/AlmanacBinding.php
+12
-1
src/applications/almanac/storage/AlmanacBinding.php
···
6
6
PhabricatorPolicyInterface,
7
7
PhabricatorCustomFieldInterface,
8
8
PhabricatorApplicationTransactionInterface,
9
-
AlmanacPropertyInterface {
9
+
AlmanacPropertyInterface,
10
+
PhabricatorDestructibleInterface {
10
11
11
12
protected $servicePHID;
12
13
protected $devicePHID;
···
203
204
204
205
return $timeline;
205
206
}
207
+
208
+
/* -( PhabricatorDestructibleInterface )----------------------------------- */
209
+
210
+
211
+
public function destroyObjectPermanently(
212
+
PhabricatorDestructionEngine $engine) {
213
+
214
+
$this->delete();
215
+
}
216
+
206
217
207
218
}