@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Switch fluid to fixed on PHUITwoColumnView
Summary: We don't ever set fluid, since it already is fluid, also no CSS. Add an actual fixed version.
Test Plan: For use in Instances.
Reviewers: epriestley
Reviewed By: epriestley
Subscribers: Korvin
Differential Revision: https://secure.phabricator.com/D18336
+13
-8
+3
-3
resources/celerity/map.php
+3
-3
resources/celerity/map.php
···
9
9
'names' => array(
10
10
'conpherence.pkg.css' => 'e68cf1fa',
11
11
'conpherence.pkg.js' => 'b5b51108',
12
-
'core.pkg.css' => '851ae625',
12
+
'core.pkg.css' => 'cc0772c6',
13
13
'core.pkg.js' => '5d80e0db',
14
14
'darkconsole.pkg.js' => '1f9a31bc',
15
15
'differential.pkg.css' => '45951e9e',
···
178
178
'rsrc/css/phui/phui-status.css' => 'd5263e49',
179
179
'rsrc/css/phui/phui-tag-view.css' => 'b4719c50',
180
180
'rsrc/css/phui/phui-timeline-view.css' => 'f21db7ca',
181
-
'rsrc/css/phui/phui-two-column-view.css' => '5b8cd553',
181
+
'rsrc/css/phui/phui-two-column-view.css' => 'ae38a939',
182
182
'rsrc/css/phui/workboards/phui-workboard-color.css' => '783cdff5',
183
183
'rsrc/css/phui/workboards/phui-workboard.css' => '3bc85455',
184
184
'rsrc/css/phui/workboards/phui-workcard.css' => 'cca5fa92',
···
874
874
'phui-tag-view-css' => 'b4719c50',
875
875
'phui-theme-css' => '9f261c6b',
876
876
'phui-timeline-view-css' => 'f21db7ca',
877
-
'phui-two-column-view-css' => '5b8cd553',
877
+
'phui-two-column-view-css' => 'ae38a939',
878
878
'phui-workboard-color-css' => '783cdff5',
879
879
'phui-workboard-view-css' => '3bc85455',
880
880
'phui-workcard-view-css' => 'cca5fa92',
+5
-5
src/view/phui/PHUITwoColumnView.php
+5
-5
src/view/phui/PHUITwoColumnView.php
···
6
6
private $sideColumn = null;
7
7
private $navigation;
8
8
private $display;
9
-
private $fluid;
9
+
private $fixed;
10
10
private $header;
11
11
private $subheader;
12
12
private $footer;
···
71
71
return $this->curtain;
72
72
}
73
73
74
-
public function setFluid($fluid) {
75
-
$this->fluid = $fluid;
74
+
public function setFixed($fixed) {
75
+
$this->fixed = $fixed;
76
76
return $this;
77
77
}
78
78
···
94
94
$classes[] = 'phui-two-column-view';
95
95
$classes[] = $this->getDisplay();
96
96
97
-
if ($this->fluid) {
98
-
$classes[] = 'phui-two-column-fluid';
97
+
if ($this->fixed) {
98
+
$classes[] = 'phui-two-column-fixed';
99
99
}
100
100
101
101
if ($this->tabs) {
+5
webroot/rsrc/css/phui/phui-two-column-view.css
+5
webroot/rsrc/css/phui/phui-two-column-view.css