@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Replace ArcanistPhutilTestCase refs with PhutilTestCase

Summary: Ref T7977. Remove the `PhabricatorTestCase::getLink` method. Depends on D12665.

Test Plan: `arc unit`.

Reviewers: avivey, #blessed_reviewers, epriestley

Reviewed By: avivey, #blessed_reviewers, epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T7977

Differential Revision: https://secure.phabricator.com/D12667

+13 -21
+5 -5
src/__phutil_library_map__.php
··· 3532 3532 'DifferentialActionEmailCommand' => 'MetaMTAEmailTransactionCommand', 3533 3533 'DifferentialActionMenuEventListener' => 'PhabricatorEventListener', 3534 3534 'DifferentialAddCommentView' => 'AphrontView', 3535 - 'DifferentialAdjustmentMapTestCase' => 'ArcanistPhutilTestCase', 3535 + 'DifferentialAdjustmentMapTestCase' => 'PhutilTestCase', 3536 3536 'DifferentialAffectedPath' => 'DifferentialDAO', 3537 3537 'DifferentialApplyPatchField' => 'DifferentialCustomField', 3538 3538 'DifferentialAsanaRepresentationField' => 'DifferentialCustomField', ··· 3597 3597 'DifferentialDiffProperty' => 'DifferentialDAO', 3598 3598 'DifferentialDiffQuery' => 'PhabricatorCursorPagedPolicyAwareQuery', 3599 3599 'DifferentialDiffTableOfContentsView' => 'AphrontView', 3600 - 'DifferentialDiffTestCase' => 'ArcanistPhutilTestCase', 3600 + 'DifferentialDiffTestCase' => 'PhutilTestCase', 3601 3601 'DifferentialDiffTransaction' => 'PhabricatorApplicationTransaction', 3602 3602 'DifferentialDiffViewController' => 'DifferentialController', 3603 3603 'DifferentialDoorkeeperRevisionFeedStoryPublisher' => 'DoorkeeperFeedStoryPublisher', ··· 3626 3626 ), 3627 3627 'DifferentialHunkParserTestCase' => 'PhabricatorTestCase', 3628 3628 'DifferentialHunkQuery' => 'PhabricatorCursorPagedPolicyAwareQuery', 3629 - 'DifferentialHunkTestCase' => 'ArcanistPhutilTestCase', 3629 + 'DifferentialHunkTestCase' => 'PhutilTestCase', 3630 3630 'DifferentialInlineComment' => 'PhabricatorInlineCommentInterface', 3631 3631 'DifferentialInlineCommentEditController' => 'PhabricatorInlineCommentController', 3632 3632 'DifferentialInlineCommentPreviewController' => 'PhabricatorInlineCommentPreviewController', ··· 3861 3861 'DiffusionTagListController' => 'DiffusionController', 3862 3862 'DiffusionTagListView' => 'DiffusionView', 3863 3863 'DiffusionTagsQueryConduitAPIMethod' => 'DiffusionQueryConduitAPIMethod', 3864 - 'DiffusionURITestCase' => 'ArcanistPhutilTestCase', 3864 + 'DiffusionURITestCase' => 'PhutilTestCase', 3865 3865 'DiffusionUpdateCoverageConduitAPIMethod' => 'DiffusionConduitAPIMethod', 3866 3866 'DiffusionView' => 'AphrontView', 3867 3867 'DivinerArticleAtomizer' => 'DivinerAtomizer', ··· 6083 6083 'PhabricatorTOTPAuthFactorTestCase' => 'PhabricatorTestCase', 6084 6084 'PhabricatorTaskmasterDaemon' => 'PhabricatorDaemon', 6085 6085 'PhabricatorTestApplication' => 'PhabricatorApplication', 6086 - 'PhabricatorTestCase' => 'ArcanistPhutilTestCase', 6086 + 'PhabricatorTestCase' => 'PhutilTestCase', 6087 6087 'PhabricatorTestController' => 'PhabricatorController', 6088 6088 'PhabricatorTestNoCycleEdgeType' => 'PhabricatorEdgeType', 6089 6089 'PhabricatorTestStorageEngine' => 'PhabricatorFileStorageEngine',
+1 -1
src/applications/differential/storage/__tests__/DifferentialAdjustmentMapTestCase.php
··· 1 1 <?php 2 2 3 - final class DifferentialAdjustmentMapTestCase extends ArcanistPhutilTestCase { 3 + final class DifferentialAdjustmentMapTestCase extends PhutilTestCase { 4 4 5 5 public function testBasicMaps() { 6 6 $change_map = array(
+1 -1
src/applications/differential/storage/__tests__/DifferentialDiffTestCase.php
··· 1 1 <?php 2 2 3 - final class DifferentialDiffTestCase extends ArcanistPhutilTestCase { 3 + final class DifferentialDiffTestCase extends PhutilTestCase { 4 4 5 5 public function testDetectCopiedCode() { 6 6 $copies = $this->detectCopiesIn('lint_engine.diff');
+1 -1
src/applications/differential/storage/__tests__/DifferentialHunkTestCase.php
··· 1 1 <?php 2 2 3 - final class DifferentialHunkTestCase extends ArcanistPhutilTestCase { 3 + final class DifferentialHunkTestCase extends PhutilTestCase { 4 4 5 5 public function testMakeChanges() { 6 6 $root = dirname(__FILE__).'/hunk/';
+1 -1
src/applications/diffusion/request/__tests__/DiffusionURITestCase.php
··· 1 1 <?php 2 2 3 - final class DiffusionURITestCase extends ArcanistPhutilTestCase { 3 + final class DiffusionURITestCase extends PhutilTestCase { 4 4 5 5 public function testBlobDecode() { 6 6 $map = array(
+2 -2
src/docs/contributor/unit_tests.diviner
··· 21 21 - Create a ##__tests__/## directory in the module if it doesn't exist yet. 22 22 - Add classes to the ##__tests__/## directory which extend from 23 23 @{class:PhabricatorTestCase} (in Phabricator) or 24 - @{class@arcanist:ArcanistPhutilTestCase} (elsewhere). 24 + @{class@arcanist:PhutilTestCase} (elsewhere). 25 25 - Run ##arc liberate## on the library root so your classes are loadable. 26 26 27 27 = Running Tests = ··· 60 60 PASS <1ms* testAllIsRightWithTheWorld 61 61 62 62 For more information on writing tests, see 63 - @{class@arcanist:ArcanistPhutilTestCase} and @{class:PhabricatorTestCase}. 63 + @{class@arcanist:PhutilTestCase} and @{class:PhabricatorTestCase}. 64 64 65 65 = Database Isolation = 66 66
+1 -1
src/docs/user/userguide/arcanist_coverage.diviner
··· 64 64 ); 65 65 66 66 You may also want to filter coverage information to the paths passed to the 67 - unit test engine. See @{class@arcanist:ArcanistPhutilTestCase} and 67 + unit test engine. See @{class@arcanist:PhutilTestCase} and 68 68 @{class@arcanist:PhutilUnitTestEngine} for an example of coverage integration 69 69 in PHP using Xdebug.
+1 -9
src/infrastructure/testing/PhabricatorTestCase.php
··· 1 1 <?php 2 2 3 - abstract class PhabricatorTestCase extends ArcanistPhutilTestCase { 3 + abstract class PhabricatorTestCase extends PhutilTestCase { 4 4 5 5 const NAMESPACE_PREFIX = 'phabricator_unittest_'; 6 6 ··· 164 164 $name = self::NAMESPACE_PREFIX.$bytes; 165 165 166 166 return new PhabricatorStorageFixtureScopeGuard($name); 167 - } 168 - 169 - protected function getLink($method) { 170 - $phabricator_project = 'PHID-APRJ-3f1fc779edeab89b2171'; 171 - return 172 - 'https://secure.phabricator.com/diffusion/symbol/'.$method. 173 - '/?lang=php&projects='.$phabricator_project. 174 - '&jump=true&context='.get_class($this); 175 167 } 176 168 177 169 /**