@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Kill phutil_render_tag()
Summary: Fixes some double escaping.
Test Plan: None.
Reviewers: epriestley
Reviewed By: epriestley
CC: aran, Korvin
Maniphest Tasks: T2432
Differential Revision: https://secure.phabricator.com/D4945
authored by
vrana
and committed by
epriestley
6ae4066d
0a08951a
+31
-29
+1
-1
src/applications/phriction/controller/PhrictionDiffController.php
+1
-1
src/applications/phriction/controller/PhrictionDiffController.php
···
116
116
'href' => '/phriction/history/'.$document->getSlug().'/',
117
117
),
118
118
'History'),
119
-
phutil_escape_html("Changes Between Version {$l} and Version {$r}"),
119
+
"Changes Between Version {$l} and Version {$r}",
120
120
));
121
121
122
122
$comparison_table = $this->renderComparisonTable(
+1
-1
src/applications/search/view/PhabricatorSearchResultView.php
+1
-1
src/applications/search/view/PhabricatorSearchResultView.php
+3
-3
src/docs/developer/rendering_html.diviner
+3
-3
src/docs/developer/rendering_html.diviner
···
168
168
169
169
phutil_tag('span', array($evil => $evil2));
170
170
171
-
// Use PhutilURI to check if $evil is valid HTTP link.
172
-
phutil_tag('a', array('href' => $evil));
173
-
174
171
phutil_tag('span', array('onmouseover' => $evil));
172
+
173
+
// Use PhutilURI to check if $evil is valid HTTP link.
174
+
hsprintf('<a href="%s">', $evil);
175
175
176
176
hsprintf('<%s>%s</%s>', $evil, $evil2, $evil);
177
177
+26
-24
src/view/form/control/AphrontFormCropControl.php
+26
-24
src/view/form/control/AphrontFormCropControl.php
···
58
58
)
59
59
);
60
60
61
-
return javelin_render_tag(
61
+
return javelin_tag(
62
62
'div',
63
63
array(
64
64
'id' => $c_id,
···
66
66
'mustcapture' => true,
67
67
'class' => 'crop-box'
68
68
),
69
-
javelin_render_tag(
70
-
'img',
71
-
array(
72
-
'src' => $file->getBestURI(),
73
-
'class' => 'crop-image',
74
-
'sigil' => 'crop-image'
69
+
array(
70
+
javelin_tag(
71
+
'img',
72
+
array(
73
+
'src' => $file->getBestURI(),
74
+
'class' => 'crop-image',
75
+
'sigil' => 'crop-image'
76
+
),
77
+
''
75
78
),
76
-
''
77
-
).
78
-
javelin_render_tag(
79
-
'input',
80
-
array(
81
-
'type' => 'hidden',
82
-
'name' => 'image_x',
83
-
'sigil' => 'crop-x',
79
+
javelin_tag(
80
+
'input',
81
+
array(
82
+
'type' => 'hidden',
83
+
'name' => 'image_x',
84
+
'sigil' => 'crop-x',
85
+
),
86
+
''
84
87
),
85
-
''
86
-
).
87
-
javelin_render_tag(
88
-
'input',
89
-
array(
90
-
'type' => 'hidden',
91
-
'name' => 'image_y',
92
-
'sigil' => 'crop-y',
88
+
javelin_tag(
89
+
'input',
90
+
array(
91
+
'type' => 'hidden',
92
+
'name' => 'image_y',
93
+
'sigil' => 'crop-y',
94
+
),
95
+
''
93
96
),
94
-
''
95
97
)
96
98
);
97
99
}