@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Further smooth "Add CC" interaction in Maniphest
Summary: Ref T2217. Fixes T3877. Improves more behaviors in the presence of "no effect" detection and new comment storage.
Test Plan: Added CCs, added existing CCs, implicitly added CCs via reassign, added CCs with comment.
Reviewers: btrahan, garoevans
Reviewed By: garoevans
CC: aran
Maniphest Tasks: T2217, T3877
Differential Revision: https://secure.phabricator.com/D7100
+2
-10
+2
-10
src/applications/maniphest/controller/ManiphestTransactionSaveController.php
+2
-10
src/applications/maniphest/controller/ManiphestTransactionSaveController.php
···
79
79
$cc_transaction = new ManiphestTransaction();
80
80
$cc_transaction
81
81
->setTransactionType(ManiphestTransactionType::TYPE_CCS);
82
-
$force_cc_transaction = false;
83
82
84
83
$transaction = new ManiphestTransaction();
85
84
$transaction
···
105
104
// Accumulate the new explicit CCs into the array that we'll add in
106
105
// the CC transaction later.
107
106
$added_ccs = array_merge($added_ccs, $request->getArr('ccs'));
108
-
109
-
// Transfer any comments over to the CC transaction.
110
-
$cc_transaction->setComments($transaction->getComments());
111
-
112
-
// Make sure we include this transaction, even if the user didn't
113
-
// actually add any CC's, because we'll discard their comment otherwise.
114
-
$force_cc_transaction = true;
115
107
116
108
// Throw away the primary transaction.
117
109
$transaction = null;
···
199
191
200
192
// Evade no-effect detection in the new editor stuff until we can switch
201
193
// to subscriptions.
202
-
$added_ccs = array_diff($added_ccs, $task->getCCPHIDs());
194
+
$added_ccs = array_filter(array_diff($added_ccs, $task->getCCPHIDs()));
203
195
204
-
if ($added_ccs || $force_cc_transaction) {
196
+
if ($added_ccs) {
205
197
// We've added CCs, so include a CC transaction.
206
198
$all_ccs = array_merge($task->getCCPHIDs(), $added_ccs);
207
199
$cc_transaction->setNewValue($all_ccs);