@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Improve some new string translations
Summary: Ref T2217. Cleans up some of the "attached %d file(s)" stuff.
Test Plan: Generated some of these transactions and verified they render more naturally.
Reviewers: btrahan, chad
Reviewed By: chad
CC: aran
Maniphest Tasks: T2217
Differential Revision: https://secure.phabricator.com/D7096
+65
-2
+2
-2
src/applications/maniphest/storage/ManiphestTransaction.php
+2
-2
src/applications/maniphest/storage/ManiphestTransaction.php
···
308
308
$this->renderHandleList($removed));
309
309
} else if ($removed && $added) {
310
310
return pht(
311
-
'%s changed projects, added %d: %s; removed %d: %s',
311
+
'%s changed project(s), added %d: %s; removed %d: %s',
312
312
$this->renderHandleLink($author_phid),
313
313
count($added),
314
314
$this->renderHandleList($added),
···
380
380
$this->renderHandleList($removed));
381
381
} else {
382
382
return pht(
383
-
'%s changed projects, attached %d: %s; detached %d: %s',
383
+
'%s changed file(s), attached %d: %s; detached %d: %s',
384
384
$this->renderHandleLink($author_phid),
385
385
count($added),
386
386
$this->renderHandleList($added),
+63
src/infrastructure/internationalization/PhabricatorBaseEnglishTranslation.php
+63
src/infrastructure/internationalization/PhabricatorBaseEnglishTranslation.php
···
682
682
'%s Commits',
683
683
),
684
684
685
+
'%s added %d project(s): %s' => array(
686
+
array(
687
+
'%s added a project: %2$s',
688
+
'%s added projects: %2$s',
689
+
),
690
+
),
691
+
692
+
'%s removed %d project(s): %s' => array(
693
+
array(
694
+
'%s removed a project: %2$s',
695
+
'%s removed projects: %2$s',
696
+
),
697
+
),
698
+
699
+
'%s changed project(s), added %d: %s; removed %d: %s' =>
700
+
'%s changed projects, added: %3$s; removed: %5$s',
701
+
702
+
'%s attached %d file(s): %s' => array(
703
+
array(
704
+
'%s attached a file: %3$s',
705
+
'%s attached files: %3$s',
706
+
),
707
+
),
708
+
709
+
'%s detached %d file(s): %s' => array(
710
+
array(
711
+
'%s detached a file: %3$s',
712
+
'%s detached files: %3$s',
713
+
),
714
+
),
715
+
716
+
'%s changed file(s), attached %d: %s; detached %d: %s' =>
717
+
'%s changed files, attached: %3$s; detached: %5$s',
718
+
719
+
720
+
'%s added %d dependencie(s): %s.' => array(
721
+
array(
722
+
'%s added a dependency: %3$s',
723
+
'%s added a dependencies: %3$s',
724
+
),
725
+
),
726
+
727
+
'%s added %d dependent task(s): %s.' => array(
728
+
array(
729
+
'%s added a dependent task: %3$s',
730
+
'%s added dependent tasks: %3$s',
731
+
),
732
+
),
733
+
734
+
'%s removed %d dependencie(s): %s.' => array(
735
+
array(
736
+
'%s removed a dependency: %3$s.',
737
+
'%s removed dependencies: %3$s.',
738
+
),
739
+
),
740
+
741
+
'%s removed %d dependent task(s): %s.' => array(
742
+
array(
743
+
'%s removed a dependent task: %3$s.',
744
+
'%s removed dependent tasks: %3$s.',
745
+
),
746
+
),
747
+
685
748
);
686
749
}
687
750