@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Delete all "force chunking" file upload code
Summary: Ref T7149. This was just to make testing easier, but chunking substantially works now.
Test Plan: `grep`
Reviewers: btrahan
Reviewed By: btrahan
Subscribers: epriestley
Maniphest Tasks: T7149
Differential Revision: https://secure.phabricator.com/D12076
-16
-13
src/applications/files/conduit/FileAllocateConduitAPIMethod.php
-13
src/applications/files/conduit/FileAllocateConduitAPIMethod.php
···
17
17
'contentLength' => 'int',
18
18
'contentHash' => 'optional string',
19
19
'viewPolicy' => 'optional string',
20
-
21
-
// TODO: Remove this, it's just here to make testing easier.
22
-
'forceChunking' => 'optional bool',
23
20
);
24
21
}
25
22
···
38
35
$name = $request->getValue('name');
39
36
$view_policy = $request->getValue('viewPolicy');
40
37
$length = $request->getValue('contentLength');
41
-
42
-
$force_chunking = $request->getValue('forceChunking');
43
38
44
39
$properties = array(
45
40
'name' => $name,
···
92
87
93
88
$engines = PhabricatorFileStorageEngine::loadStorageEngines($length);
94
89
if ($engines) {
95
-
96
-
if ($force_chunking) {
97
-
foreach ($engines as $key => $engine) {
98
-
if (!$engine->isChunkEngine()) {
99
-
unset($engines[$key]);
100
-
}
101
-
}
102
-
}
103
90
104
91
// Pick the first engine. If the file is small enough to fit into a
105
92
// single engine without chunking, this will be a non-chunk engine and
-3
src/applications/files/controller/PhabricatorFileDropUploadController.php
-3
src/applications/files/controller/PhabricatorFileDropUploadController.php