@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Examine fewer daemons for variant config
Summary:
Right now, if a daemon dies it can leave the setup warning around for like 10 minutes or something until we reap it.
Tighten the warning so we only care about actively running daemons.
Test Plan: Checked setup issues.
Reviewers: btrahan
Reviewed By: btrahan
Subscribers: epriestley
Differential Revision: https://secure.phabricator.com/D12088
+6
-1
+1
-1
src/applications/config/check/PhabricatorDaemonsSetupCheck.php
+1
-1
src/applications/config/check/PhabricatorDaemonsSetupCheck.php
···
10
10
11
11
$task_daemon = id(new PhabricatorDaemonLogQuery())
12
12
->setViewer(PhabricatorUser::getOmnipotentUser())
13
-
->withStatus(PhabricatorDaemonLogQuery::STATUS_ALIVE)
13
+
->withStatus(PhabricatorDaemonLogQuery::STATUS_RUNNING)
14
14
->withDaemonClasses(array('PhabricatorTaskmasterDaemon'))
15
15
->setLimit(1)
16
16
->execute();
+5
src/applications/daemon/query/PhabricatorDaemonLogQuery.php
+5
src/applications/daemon/query/PhabricatorDaemonLogQuery.php
···
5
5
6
6
const STATUS_ALL = 'status-all';
7
7
const STATUS_ALIVE = 'status-alive';
8
+
const STATUS_RUNNING = 'status-running';
8
9
9
10
private $ids;
10
11
private $notIDs;
···
170
171
switch ($status) {
171
172
case self::STATUS_ALL:
172
173
return array();
174
+
case self::STATUS_RUNNING:
175
+
return array(
176
+
PhabricatorDaemonLog::STATUS_RUNNING,
177
+
);
173
178
case self::STATUS_ALIVE:
174
179
return array(
175
180
PhabricatorDaemonLog::STATUS_UNKNOWN,