recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix PHP 8.1 "strlen(null)" exception for no query in primary search

Summary:
`strlen()` was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts `phutil_nonempty_string()` as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

```
ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/search/controller/PhabricatorSearchController.php:34]
```

Test Plan: Visit `http://phorge.localhost/search/?search:primary=true`

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Differential Revision: https://we.phorge.it/D26061

Andre Klapper 6d219783 a638bafe

+1 -1
+1 -1
src/applications/search/controller/PhabricatorSearchController.php
··· 31 31 if ($request->getBool('search:primary')) { 32 32 33 33 // If there's no query, just take the user to advanced search. 34 - if (!strlen($query)) { 34 + if (!phutil_nonempty_string($query)) { 35 35 $advanced_uri = '/search/query/advanced/'; 36 36 return id(new AphrontRedirectResponse())->setURI($advanced_uri); 37 37 }