@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Layout Phriction actions without floats, to avoid conflicts with floating content
Summary:
Ref T13195. If a Phriction page begins with a code block, the `clear: both;` currently makes it clear the action list.
Instead, use table-cell layout on desktops.
Test Plan: Viewed a Phriction page with an initial code block on desktop/tablet/mobile/printable layouts. Now got more sensible layouts in all cases.
Reviewers: amckinley
Reviewed By: amckinley
Subscribers: GoogleLegacy
Maniphest Tasks: T13195
Differential Revision: https://secure.phabricator.com/D19649
+29
-9
+2
-2
resources/celerity/map.php
+2
-2
resources/celerity/map.php
···
146
146
'rsrc/css/phui/phui-comment-panel.css' => 'f50152ad',
147
147
'rsrc/css/phui/phui-crumbs-view.css' => '10728aaa',
148
148
'rsrc/css/phui/phui-curtain-view.css' => '2bdaf026',
149
-
'rsrc/css/phui/phui-document-pro.css' => '0e41dd91',
149
+
'rsrc/css/phui/phui-document-pro.css' => '1a08ef4b',
150
150
'rsrc/css/phui/phui-document-summary.css' => '9ca48bdf',
151
151
'rsrc/css/phui/phui-document.css' => 'c4ac41f9',
152
152
'rsrc/css/phui/phui-feed-story.css' => '44a9c8e9',
···
814
814
'phui-curtain-view-css' => '2bdaf026',
815
815
'phui-document-summary-view-css' => '9ca48bdf',
816
816
'phui-document-view-css' => 'c4ac41f9',
817
-
'phui-document-view-pro-css' => '0e41dd91',
817
+
'phui-document-view-pro-css' => '1a08ef4b',
818
818
'phui-feed-story-css' => '44a9c8e9',
819
819
'phui-font-icon-base-css' => '870a7360',
820
820
'phui-fontkit-css' => '1320ed01',
+14
-4
src/view/phui/PHUIDocumentView.php
+14
-4
src/view/phui/PHUIDocumentView.php
···
171
171
$table_of_contents,
172
172
$this->header,
173
173
$this->banner,
174
-
array(
175
-
$curtain,
176
-
$main_content,
177
-
),
174
+
phutil_tag(
175
+
'div',
176
+
array(
177
+
'class' => 'phui-document-content-outer',
178
+
),
179
+
phutil_tag(
180
+
'div',
181
+
array(
182
+
'class' => 'phui-document-content-inner',
183
+
),
184
+
array(
185
+
$main_content,
186
+
$curtain,
187
+
))),
178
188
$foot_content,
179
189
));
180
190
+13
-3
webroot/rsrc/css/phui/phui-document-pro.css
+13
-3
webroot/rsrc/css/phui/phui-document-pro.css
···
4
4
5
5
.phui-document-view.phui-document-view-pro {
6
6
max-width: 800px;
7
-
padding: 16px 16px 64px 16px;
7
+
padding: 16px 16px 32px 16px;
8
8
margin: 0 auto;
9
9
}
10
10
···
21
21
}
22
22
23
23
.device-desktop .has-curtain .phui-document-content-view {
24
-
padding-right: 332px;
24
+
display: table-cell;
25
25
}
26
26
27
27
.printable .phui-document-content-view {
28
28
padding-right: 0;
29
29
}
30
30
31
+
.device-desktop .phui-document-content-outer {
32
+
display: table;
33
+
width: 100%;
34
+
layout: fixed;
35
+
}
36
+
37
+
.device-desktop .phui-document-content-inner {
38
+
display: table-row;
39
+
}
40
+
31
41
.device-desktop .phui-document-curtain {
32
-
float: right;
42
+
display: table-cell;
33
43
width: 300px;
34
44
}
35
45