recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Styling up Jump Nav text box

Summary:
This actually gives it a smooth look across all OS and browsers. Copy-paste from form inputs.

= Motivation (aka Disclaimer) =

I felt kind of... disturbed that it looked different in every browser / OS combination I have at my disposal. The range is from ugly (Chrome on Ubuntu) to pretty (IE9 on Win7 ¬.¬). I give a few examples

- Ubuntu
- Firefox
- Actually looking very nice. Rounded borders and orange border on focus are default from UA style sheet?
- Chrome
- Looks ugly. 2px inset mid-grey border. What you would expect from Win '95
- 1px inset mid-grey border (Win '98 style) + orange webkit outline.
- Windows
- IE9
- Nice blocky text input with black border. Blue border upon hover. Really black border on focus?
- IE10
- Kind of same as IE9, though I had the feeling that it had a deeper black border
- Firefox
- Looks so normal that it is actually boring
- Chrome
- Looks pretty much normal, until focus where you get the webkit outlines. Ugly

No Mac, since I have no Mac. Also no iPhone/iPad. Have Android 4.1/WP8, though I never visited Phabricator with them

Test Plan:
Looked at it in

- Ubuntu
- Mozilla Firefox
- Google Chrome
- Windows 7/8
- IE 9/10
- Opera (Opera?)
- Mozilla Firefox
- Google Chrome

Everything smooth (exceptions in case of no border-radius/box-shadow)

Reviewers: epriestley, btrahan, chad

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D5515

authored by

Anh Nhan Nguyen and committed by
epriestley 6e197fe9 48f1a578

+43 -40
+39 -39
src/__celerity_resource_map__.php
··· 2975 2975 ), 2976 2976 'phabricator-jump-nav' => 2977 2977 array( 2978 - 'uri' => '/res/2e0e2211/rsrc/css/application/directory/phabricator-jump-nav.css', 2978 + 'uri' => '/res/a5927be8/rsrc/css/application/directory/phabricator-jump-nav.css', 2979 2979 'type' => 'css', 2980 2980 'requires' => 2981 2981 array( ··· 3805 3805 ), array( 3806 3806 'packages' => 3807 3807 array( 3808 - '4fc2a8f9' => 3808 + '341e7351' => 3809 3809 array( 3810 3810 'name' => 'core.pkg.css', 3811 3811 'symbols' => ··· 3847 3847 34 => 'phabricator-object-item-list-view-css', 3848 3848 35 => 'global-drag-and-drop-css', 3849 3849 ), 3850 - 'uri' => '/res/pkg/4fc2a8f9/core.pkg.css', 3850 + 'uri' => '/res/pkg/341e7351/core.pkg.css', 3851 3851 'type' => 'css', 3852 3852 ), 3853 3853 'def4c982' => ··· 4038 4038 'reverse' => 4039 4039 array( 4040 4040 'aphront-attached-file-view-css' => '6b1fccc6', 4041 - 'aphront-dialog-view-css' => '4fc2a8f9', 4042 - 'aphront-error-view-css' => '4fc2a8f9', 4043 - 'aphront-form-view-css' => '4fc2a8f9', 4044 - 'aphront-list-filter-view-css' => '4fc2a8f9', 4045 - 'aphront-pager-view-css' => '4fc2a8f9', 4046 - 'aphront-panel-view-css' => '4fc2a8f9', 4047 - 'aphront-table-view-css' => '4fc2a8f9', 4048 - 'aphront-tokenizer-control-css' => '4fc2a8f9', 4049 - 'aphront-tooltip-css' => '4fc2a8f9', 4050 - 'aphront-typeahead-control-css' => '4fc2a8f9', 4041 + 'aphront-dialog-view-css' => '341e7351', 4042 + 'aphront-error-view-css' => '341e7351', 4043 + 'aphront-form-view-css' => '341e7351', 4044 + 'aphront-list-filter-view-css' => '341e7351', 4045 + 'aphront-pager-view-css' => '341e7351', 4046 + 'aphront-panel-view-css' => '341e7351', 4047 + 'aphront-table-view-css' => '341e7351', 4048 + 'aphront-tokenizer-control-css' => '341e7351', 4049 + 'aphront-tooltip-css' => '341e7351', 4050 + 'aphront-typeahead-control-css' => '341e7351', 4051 4051 'differential-changeset-view-css' => '8aaacd1b', 4052 4052 'differential-core-view-css' => '8aaacd1b', 4053 4053 'differential-inline-comment-editor' => '67ea27d0', ··· 4061 4061 'differential-table-of-contents-css' => '8aaacd1b', 4062 4062 'diffusion-commit-view-css' => 'c8ce2d88', 4063 4063 'diffusion-icons-css' => 'c8ce2d88', 4064 - 'global-drag-and-drop-css' => '4fc2a8f9', 4064 + 'global-drag-and-drop-css' => '341e7351', 4065 4065 'inline-comment-summary-css' => '8aaacd1b', 4066 4066 'javelin-aphlict' => 'def4c982', 4067 4067 'javelin-behavior' => 'fe22443b', ··· 4133 4133 'javelin-util' => 'fe22443b', 4134 4134 'javelin-vector' => 'fe22443b', 4135 4135 'javelin-workflow' => 'fe22443b', 4136 - 'lightbox-attachment-css' => '4fc2a8f9', 4136 + 'lightbox-attachment-css' => '341e7351', 4137 4137 'maniphest-task-summary-css' => '6b1fccc6', 4138 4138 'maniphest-transaction-detail-css' => '6b1fccc6', 4139 4139 'phabricator-busy' => 'def4c982', 4140 4140 'phabricator-content-source-view-css' => '8aaacd1b', 4141 - 'phabricator-core-buttons-css' => '4fc2a8f9', 4142 - 'phabricator-core-css' => '4fc2a8f9', 4143 - 'phabricator-crumbs-view-css' => '4fc2a8f9', 4144 - 'phabricator-directory-css' => '4fc2a8f9', 4141 + 'phabricator-core-buttons-css' => '341e7351', 4142 + 'phabricator-core-css' => '341e7351', 4143 + 'phabricator-crumbs-view-css' => '341e7351', 4144 + 'phabricator-directory-css' => '341e7351', 4145 4145 'phabricator-drag-and-drop-file-upload' => '67ea27d0', 4146 4146 'phabricator-dropdown-menu' => 'def4c982', 4147 4147 'phabricator-file-upload' => 'def4c982', 4148 - 'phabricator-filetree-view-css' => '4fc2a8f9', 4149 - 'phabricator-flag-css' => '4fc2a8f9', 4150 - 'phabricator-form-view-css' => '4fc2a8f9', 4151 - 'phabricator-header-view-css' => '4fc2a8f9', 4152 - 'phabricator-jump-nav' => '4fc2a8f9', 4148 + 'phabricator-filetree-view-css' => '341e7351', 4149 + 'phabricator-flag-css' => '341e7351', 4150 + 'phabricator-form-view-css' => '341e7351', 4151 + 'phabricator-header-view-css' => '341e7351', 4152 + 'phabricator-jump-nav' => '341e7351', 4153 4153 'phabricator-keyboard-shortcut' => 'def4c982', 4154 4154 'phabricator-keyboard-shortcut-manager' => 'def4c982', 4155 - 'phabricator-main-menu-view' => '4fc2a8f9', 4155 + 'phabricator-main-menu-view' => '341e7351', 4156 4156 'phabricator-menu-item' => 'def4c982', 4157 - 'phabricator-nav-view-css' => '4fc2a8f9', 4157 + 'phabricator-nav-view-css' => '341e7351', 4158 4158 'phabricator-notification' => 'def4c982', 4159 - 'phabricator-notification-css' => '4fc2a8f9', 4160 - 'phabricator-notification-menu-css' => '4fc2a8f9', 4161 - 'phabricator-object-item-list-view-css' => '4fc2a8f9', 4159 + 'phabricator-notification-css' => '341e7351', 4160 + 'phabricator-notification-menu-css' => '341e7351', 4161 + 'phabricator-object-item-list-view-css' => '341e7351', 4162 4162 'phabricator-object-selector-css' => '8aaacd1b', 4163 4163 'phabricator-paste-file-upload' => 'def4c982', 4164 4164 'phabricator-prefab' => 'def4c982', 4165 4165 'phabricator-project-tag-css' => '6b1fccc6', 4166 - 'phabricator-remarkup-css' => '4fc2a8f9', 4166 + 'phabricator-remarkup-css' => '341e7351', 4167 4167 'phabricator-shaped-request' => '67ea27d0', 4168 - 'phabricator-side-menu-view-css' => '4fc2a8f9', 4169 - 'phabricator-standard-page-view' => '4fc2a8f9', 4168 + 'phabricator-side-menu-view-css' => '341e7351', 4169 + 'phabricator-standard-page-view' => '341e7351', 4170 4170 'phabricator-textareautils' => 'def4c982', 4171 4171 'phabricator-tooltip' => 'def4c982', 4172 - 'phabricator-transaction-view-css' => '4fc2a8f9', 4173 - 'phabricator-zindex-css' => '4fc2a8f9', 4174 - 'sprite-apps-large-css' => '4fc2a8f9', 4175 - 'sprite-gradient-css' => '4fc2a8f9', 4176 - 'sprite-icon-css' => '4fc2a8f9', 4177 - 'sprite-menu-css' => '4fc2a8f9', 4178 - 'syntax-highlighting-css' => '4fc2a8f9', 4172 + 'phabricator-transaction-view-css' => '341e7351', 4173 + 'phabricator-zindex-css' => '341e7351', 4174 + 'sprite-apps-large-css' => '341e7351', 4175 + 'sprite-gradient-css' => '341e7351', 4176 + 'sprite-icon-css' => '341e7351', 4177 + 'sprite-menu-css' => '341e7351', 4178 + 'syntax-highlighting-css' => '341e7351', 4179 4179 ), 4180 4180 ));
+4 -1
webroot/rsrc/css/application/directory/phabricator-jump-nav.css
··· 11 11 .phabricator-jump-nav { 12 12 font-size: 16px; 13 13 width: 100%; 14 - padding: 2px 0; 14 + padding: 4px; 15 + border-radius: 3px; 16 + border: 1px solid #96A6C5; 17 + box-shadow: inset 0 1px 1px rgba(0, 0, 0, 0.075); 15 18 } 16 19 17 20 .phabricator-jump-nav-caption {