@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Clean up Project Board Manage / Column Manage pages
Summary: Slightly nicer, more consistent UI. Also removed "Column History" from dropdowns as this is available on the general board manage page.
Test Plan: Review Board and Column management pages.
Reviewers: epriestley
Reviewed By: epriestley
Subscribers: Korvin
Differential Revision: https://secure.phabricator.com/D17881
+30
-56
+4
-1
src/applications/project/controller/PhabricatorProjectBoardManageController.php
+4
-1
src/applications/project/controller/PhabricatorProjectBoardManageController.php
···
40
40
$nav = $this->getProfileMenu();
41
41
$columns_list = $this->buildColumnsList($board, $columns);
42
42
43
+
require_celerity_resource('project-view-css');
44
+
43
45
$view = id(new PHUITwoColumnView())
44
46
->setHeader($header)
47
+
->addClass('project-view-home')
48
+
->addClass('project-view-people-home')
45
49
->setFooter($columns_list);
46
50
47
51
$title = array(
···
78
82
$header = id(new PHUIHeaderView())
79
83
->setHeader(pht('Workboard: %s', $board->getDisplayName()))
80
84
->setUser($viewer)
81
-
->setPolicyObject($board)
82
85
->setProfileHeader(true)
83
86
->addActionLink($button);
84
87
-6
src/applications/project/controller/PhabricatorProjectBoardViewController.php
-6
src/applications/project/controller/PhabricatorProjectBoardViewController.php
···
879
879
->setWorkflow(true);
880
880
}
881
881
882
-
$details_uri = 'board/'.$this->id.'/column/'.$column->getID().'/';
883
-
$column_items[] = id(new PhabricatorActionView())
884
-
->setName(pht('Column History'))
885
-
->setIcon('fa-columns')
886
-
->setHref($this->getApplicationURI($details_uri));
887
-
888
882
$column_menu = id(new PhabricatorActionListView())
889
883
->setUser($viewer);
890
884
foreach ($column_items as $item) {
+25
-45
src/applications/project/controller/PhabricatorProjectColumnDetailController.php
+25
-45
src/applications/project/controller/PhabricatorProjectColumnDetailController.php
···
44
44
$title = $column->getDisplayName();
45
45
46
46
$header = $this->buildHeaderView($column);
47
-
$actions = $this->buildActionView($column);
48
-
$properties = $this->buildPropertyView($column, $actions);
47
+
$properties = $this->buildPropertyView($column);
49
48
50
49
$crumbs = $this->buildApplicationCrumbs();
51
50
$crumbs->addTextCrumb(pht('Workboard'), "/project/board/{$project_id}/");
52
51
$crumbs->addTextCrumb(pht('Column: %s', $title));
53
-
54
-
$box = id(new PHUIObjectBoxView())
55
-
->setHeader($header)
56
-
->addPropertyList($properties);
52
+
$crumbs->setBorder(true);
57
53
58
54
$nav = $this->getProfileMenu();
55
+
require_celerity_resource('project-view-css');
56
+
57
+
$view = id(new PHUITwoColumnView())
58
+
->setHeader($header)
59
+
->addClass('project-view-home')
60
+
->addClass('project-view-people-home')
61
+
->setMainColumn(array(
62
+
$properties,
63
+
$timeline,
64
+
));
59
65
60
66
return $this->newPage()
61
67
->setTitle($title)
62
68
->setNavigation($nav)
63
69
->setCrumbs($crumbs)
64
-
->appendChild(
65
-
array(
66
-
$box,
67
-
$timeline,
68
-
));
70
+
->appendChild($view);
69
71
}
70
72
71
73
private function buildHeaderView(PhabricatorProjectColumn $column) {
72
-
$viewer = $this->getRequest()->getUser();
74
+
$viewer = $this->getViewer();
73
75
74
76
$header = id(new PHUIHeaderView())
77
+
->setHeader(pht('Column: %s', $column->getDisplayName()))
75
78
->setUser($viewer)
76
-
->setHeader($column->getDisplayName());
79
+
->setProfileHeader(true);
77
80
78
81
if ($column->isHidden()) {
79
82
$header->setStatus('fa-ban', 'dark', pht('Hidden'));
···
82
85
return $header;
83
86
}
84
87
85
-
private function buildActionView(PhabricatorProjectColumn $column) {
86
-
$viewer = $this->getRequest()->getUser();
87
-
88
-
$id = $column->getID();
89
-
$project_id = $this->getProject()->getID();
90
-
$base_uri = '/board/'.$project_id.'/';
91
-
92
-
$actions = id(new PhabricatorActionListView())
93
-
->setUser($viewer);
94
-
95
-
$can_edit = PhabricatorPolicyFilter::hasCapability(
96
-
$viewer,
97
-
$column,
98
-
PhabricatorPolicyCapability::CAN_EDIT);
99
-
100
-
$actions->addAction(
101
-
id(new PhabricatorActionView())
102
-
->setName(pht('Edit Column'))
103
-
->setIcon('fa-pencil')
104
-
->setHref($this->getApplicationURI($base_uri.'edit/'.$id.'/'))
105
-
->setDisabled(!$can_edit)
106
-
->setWorkflow(true));
107
-
108
-
return $actions;
109
-
}
110
-
111
88
private function buildPropertyView(
112
-
PhabricatorProjectColumn $column,
113
-
PhabricatorActionListView $actions) {
114
-
$viewer = $this->getRequest()->getUser();
89
+
PhabricatorProjectColumn $column) {
90
+
$viewer = $this->getViewer();
115
91
116
92
$properties = id(new PHUIPropertyListView())
117
93
->setUser($viewer)
118
-
->setObject($column)
119
-
->setActionList($actions);
94
+
->setObject($column);
120
95
121
96
$limit = $column->getPointLimit();
122
97
if ($limit === null) {
···
126
101
}
127
102
$properties->addProperty(pht('Point Limit'), $limit_text);
128
103
129
-
return $properties;
104
+
$box = id(new PHUIObjectBoxView())
105
+
->setHeaderText(pht('Details'))
106
+
->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
107
+
->appendChild($properties);
108
+
109
+
return $box;
130
110
}
131
111
132
112
}
+1
-4
src/applications/project/controller/PhabricatorProjectProfileController.php
+1
-4
src/applications/project/controller/PhabricatorProjectProfileController.php